Fix handling of Github API paths and add tests

This commit is contained in:
Joseph Schorr 2016-06-30 14:10:22 -04:00
parent cf947962dc
commit 9558c0e937
3 changed files with 60 additions and 1 deletions

View file

@ -209,8 +209,15 @@ class TestSlashJoining(unittest.TestCase):
test_cases = [
(['https://github.com', '/coreos-inc/' 'quay/pull/1092/files'],
'https://github.com/coreos-inc/quay/pull/1092/files'),
(['https://', 'github.com/', '/coreos-inc', '/quay/pull/1092/files/'],
'https://github.com/coreos-inc/quay/pull/1092/files'),
(['https://somegithub.com/', '/api/v3/'],
'https://somegithub.com/api/v3'),
(['https://github.somedomain.com/', '/api/v3/'],
'https://github.somedomain.com/api/v3'),
]
for args, url in test_cases: