vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Refactor Manage Trigger to Single Workflow (#2577)

Browse source 
* Refactor Manage Trigger to Single Workflow
This commit is contained in:
Alec Merdler 2017-05-22 13:59:12 -07:00 • committed by GitHub
parent d122743129
commit 97256841bd
26 changed files with 1262 additions and 1077 deletions
Download patch file Download diff file Expand all files Collapse all files

32
static/js/directives/ui/context-path-select/context-path-select.component.spec.ts
View file

@ -1,4 +1,4 @@
import { ContextPathSelectComponent } from './context-path-select.component';
import { ContextPathSelectComponent, ContextChangeEvent } from './context-path-select.component';
describe("ContextPathSelectComponent", () => {
@ -57,23 +57,33 @@ describe("ContextPathSelectComponent", () => {
expect(component.isValidContext).toBe(false);
});
it("emits output event indicating build context changed", (done) => {
component.contextChanged.subscribe((event: ContextChangeEvent) => {
expect(event.contextDir).toEqual(newContext);
expect(event.isValid).toEqual(component.isValidContext);
done();
});
component.setContext(newContext);
});
});
describe("setSelectedContext", () => {
var context: string;
var newContext: string;
beforeEach(() => {
context = '/conf';
newContext = '/conf';
});
it("sets current context to given context", () => {
component.setSelectedContext(context);
component.setSelectedContext(newContext);
expect(component.currentContext).toEqual(context);
expect(component.currentContext).toEqual(newContext);
});
it("sets valid context flag to true if given context is valid", () => {
component.setSelectedContext(context);
component.setSelectedContext(newContext);
expect(component.isValidContext).toBe(true);
});
@ -83,5 +93,15 @@ describe("ContextPathSelectComponent", () => {
expect(component.isValidContext).toBe(false);
});
it("emits output event indicating build context changed", (done) => {
component.contextChanged.subscribe((event: ContextChangeEvent) => {
expect(event.contextDir).toEqual(newContext);
expect(event.isValid).toEqual(component.isValidContext);
done();
});
component.setSelectedContext(newContext);
});
});
});

25
static/js/directives/ui/context-path-select/context-path-select.component.ts
View file

@ -1,4 +1,4 @@
import { Input, Component, OnChanges, SimpleChanges } from 'ng-metadata/core';
import { Input, Component, OnChanges, SimpleChanges, Output, EventEmitter } from 'ng-metadata/core';
/**
@ -10,10 +10,10 @@ import { Input, Component, OnChanges, SimpleChanges } from 'ng-metadata/core';
})
export class ContextPathSelectComponent implements OnChanges {
// FIXME: Use one-way data binding
@Input('=') public currentContext: string = '';
@Input('=') public isValidContext: boolean;
@Input('=') public contexts: string[];
@Input('<') public currentContext: string = '';
@Input('<') public contexts: string[];
@Output() public contextChanged: EventEmitter<ContextChangeEvent> = new EventEmitter();
public isValidContext: boolean;
private isUnknownContext: boolean = true;
private selectedContext: string | null = null;
@ -25,12 +25,16 @@ export class ContextPathSelectComponent implements OnChanges {
this.currentContext = context;
this.selectedContext = null;
this.isValidContext = this.checkContext(context, this.contexts);
this.contextChanged.emit({contextDir: context, isValid: this.isValidContext});
}
public setSelectedContext(context: string): void {
this.currentContext = context;
this.selectedContext = context;
this.isValidContext = this.checkContext(context, this.contexts);
this.contextChanged.emit({contextDir: context, isValid: this.isValidContext});
}
private checkContext(context: string = '', contexts: string[] = []): boolean {
@ -39,8 +43,17 @@ export class ContextPathSelectComponent implements OnChanges {
if (context.length > 0 && context[0] === '/') {
isValidContext = true;
this.isUnknownContext = true;
this.isUnknownContext = contexts.indexOf(context) != -1;
}
return isValidContext;
}
}
/**
* Build context changed event.
*/
export type ContextChangeEvent = {
contextDir: string;
isValid: boolean;
};