Merge branch 'master' into tutorial

Conflicts:
	endpoints/index.py
	static/css/quay.css
	static/js/app.js
	static/js/controllers.js
	test/data/test.db

endpoints/api.py

@@ -262,7 +262,6 @@ def convert_user_to_organization():
 @internal_api_call
 def change_user_details():
   user = current_user.db_user()
-
   user_data = request.get_json()
 
   try:
@@ -315,6 +314,8 @@ def create_new_user():
 @internal_api_call
 def signin_user():
   signin_data = request.get_json()
+  if not signin_data:
+    abort(404)
 
   username = signin_data['username']
   password = signin_data['password']
@@ -421,6 +422,7 @@ def get_matching_entities(prefix):
 
   team_data = [entity_team_view(team) for team in teams]
   user_data = [user_view(user) for user in users]
+
   return jsonify({
     'results': team_data + user_data
   })
@@ -446,11 +448,16 @@ def create_organization():
   existing = None
 
   try:
-    existing = (model.get_organization(org_data['name']) or
-                model.get_user(org_data['name']))
+    existing = model.get_organization(org_data['name'])
   except model.InvalidOrganizationException:
     pass
 
+  if not existing:
+    try:
+      existing = model.get_user(org_data['name'])
+    except model.InvalidUserException:
+      pass
+
   if existing:
     msg = 'A user or organization with this name already exists'
     return request_error(message=msg)
@@ -604,9 +611,9 @@ def create_organization_prototype_permission(orgname):
         'name' in details['activating_user']):
       activating_username = details['activating_user']['name']
     
-    delegate = details['delegate']
-    delegate_kind = delegate['kind']
-    delegate_name = delegate['name']
+    delegate = details['delegate'] if 'delegate' in details else {}
+    delegate_kind = delegate.get('kind', None)
+    delegate_name = delegate.get('name', None)
 
     delegate_username = delegate_name if delegate_kind == 'user' else None
     delegate_teamname = delegate_name if delegate_kind == 'team' else None
@@ -622,7 +629,7 @@ def create_organization_prototype_permission(orgname):
       return request_error(message='Unknown activating user')
 
     if not delegate_user and not delegate_team:
-      return request_error(message='Missing delagate user or team')
+      return request_error(message='Missing delegate user or team')
 
     role_name = details['role']
 
@@ -1278,7 +1285,11 @@ def create_webhook(namespace, repository):
 def get_webhook(namespace, repository, public_id):
   permission = AdministerRepositoryPermission(namespace, repository)
   if permission.can():
-    webhook = model.get_webhook(namespace, repository, public_id)
+    try:
+      webhook = model.get_webhook(namespace, repository, public_id)
+    except model.InvalidWebhookException:
+      abort(404)
+
     return jsonify(webhook_view(webhook))
 
   abort(403)  # Permission denied
@@ -1673,7 +1684,11 @@ def list_repo_tokens(namespace, repository):
 def get_tokens(namespace, repository, code):
   permission = AdministerRepositoryPermission(namespace, repository)
   if permission.can():
-    perm = model.get_repo_delegate_token(namespace, repository, code)
+    try:
+      perm = model.get_repo_delegate_token(namespace, repository, code)
+    except model.InvalidTokenException:
+      abort(404)
+
     return jsonify(token_view(perm))
 
   abort(403)  # Permission denied
@@ -1810,6 +1825,8 @@ def set_card(user, token):
         cus.save()
       except stripe.CardError as e:
         return carderror_response(e)
+      except stripe.InvalidRequestError as e:
+        return carderror_response(e)
 
   return get_card(user)
 

endpoints/index.py

@@ -255,6 +255,8 @@ def update_images(namespace, repository):
       event = app.config['USER_EVENTS'].get_event(username)
       event.publish_event_data('docker-cli', user_data)
 
+    num_removed = model.garbage_collect_repository(namespace, repository)
+
     # Generate a job for each webhook that has been added to this repo
     webhooks = model.list_webhooks(namespace, repository)
     for webhook in webhooks:
@@ -270,7 +272,8 @@ def update_images(namespace, repository):
         'homepage': 'https://quay.io/repository/%s' % repo_string,
         'visibility': repo.visibility.name,
         'updated_tags': updated_tags,
-        'pushed_image_count': len(image_with_checksums), 
+        'pushed_image_count': len(image_with_checksums),
+        'pruned_image_count': num_removed,
       }
       webhook_queue.put(json.dumps(webhook_data))
 

endpoints/tags.py

@@ -73,22 +73,8 @@ def delete_tag(namespace, repository, tag):
 
   if permission.can():
     model.delete_tag(namespace, repository, tag)
+    model.garbage_collect_repository(namespace, repository)
 
-    return make_response('Deleted', 204)
-
-  abort(403)
-
-
-@tags.route('/repositories/<path:repository>/tags',
-           methods=['DELETE'])
-@process_auth
-@parse_repository_name
-def delete_repository_tags(namespace, repository):
-  permission = ModifyRepositoryPermission(namespace, repository)
-
-  if permission.can():
-    model.delete_all_repository_tags(namespace, repository)
-
-    return make_response('Deleted', 204)
+    return make_response('Deleted', 200)
 
   abort(403)

endpoints/web.py

@@ -94,6 +94,12 @@ def contact():
   return index('')
 
 
+@web.route('/about/')
+@no_cache
+def about():
+  return index('')
+
+
 @web.route('/new/')
 @no_cache
 def new():