vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Better handling of retries on build errors

Browse source
This commit is contained in:
Joseph Schorr 2015-02-03 16:29:47 -05:00
parent 3bf5e93f06
commit a1938593a9
3 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
buildman/jobutil/workererror.py
View file

@ -25,7 +25,8 @@ class WorkerError(object):
}, },
'io.quay.builder.internalerror': { 'io.quay.builder.internalerror': {
'message': 'An internal error occurred while building. Please submit a ticket.' 'message': 'An internal error occurred while building. Please submit a ticket.',
'is_internal': True
}, },
'io.quay.builder.buildrunerror': { 'io.quay.builder.buildrunerror': {

4
buildman/server.py
View file

@ -125,9 +125,7 @@ class BuilderServer(object):
def _job_complete(self, build_job, job_status): def _job_complete(self, build_job, job_status):
if job_status == BuildJobResult.INCOMPLETE: if job_status == BuildJobResult.INCOMPLETE:
self._queue.incomplete(build_job.job_item, restore_retry=True, retry_after=30) self._queue.incomplete(build_job.job_item, restore_retry=False, retry_after=30)
elif job_status == BuildJobResult.ERROR:
self._queue.incomplete(build_job.job_item, restore_retry=False)
else: else:
self._queue.complete(build_job.job_item) self._queue.complete(build_job.job_item)

2
endpoints/common.py
View file

@ -211,7 +211,7 @@ def start_build(repository, dockerfile_id, tags, build_name, subdir, manual,
dockerfile_build_queue.put([repository.namespace_user.username, repository.name], json.dumps({ dockerfile_build_queue.put([repository.namespace_user.username, repository.name], json.dumps({
'build_uuid': build_request.uuid, 'build_uuid': build_request.uuid,
'pull_credentials': model.get_pull_credentials(pull_robot_name) if pull_robot_name else None 'pull_credentials': model.get_pull_credentials(pull_robot_name) if pull_robot_name else None
}), retries_remaining=2) }), retries_remaining=3)
# Add the build to the repo's log. # Add the build to the repo's log.
metadata = { metadata = {