From a313a77a6b7d1551f6ea8e8773960a6818c530f0 Mon Sep 17 00:00:00 2001
From: yackob03 <jacob.moshenko@gmail.com>
Date: Tue, 29 Oct 2013 13:41:26 -0400
Subject: [PATCH] Switch some unnecessary button calls over to links.

---
 static/js/controllers.js       | 12 ------------
 static/partials/landing.html   |  4 ++--
 static/partials/v1-page.html   |  2 +-
 static/partials/view-repo.html |  8 ++++----
 4 files changed, 7 insertions(+), 19 deletions(-)

diff --git a/static/js/controllers.js b/static/js/controllers.js
index df1ea6e22..b83be8ca8 100644
--- a/static/js/controllers.js
+++ b/static/js/controllers.js
@@ -229,14 +229,6 @@ function LandingCtrl($scope, $timeout, $location, Restangular, UserService, KeyS
     return getMarkedDown(getFirstTextLine(commentString));
   };
 
-  $scope.browseRepos = function() {
-    $location.path('/repository/');
-  };
-
-  $scope.createRepo = function() {
-    $location.path('/new/');
-  };
-
   $scope.register = function() {
     $('.form-signup').popover('hide');
     $scope.registering = true;
@@ -896,10 +888,6 @@ function V1Ctrl($scope, $location, UserService) {
   $scope.$watch( function () { return UserService.currentUser(); }, function (currentUser) {
     $scope.user = currentUser;
   }, true);
-
-  $scope.browseRepos = function() {
-    $location.path('/repository/');
-  };
 }
 
 function NewRepoCtrl($scope, $location, $http, UserService, Restangular, PlanService) {
diff --git a/static/partials/landing.html b/static/partials/landing.html
index b53b4504f..4e3426972 100644
--- a/static/partials/landing.html
+++ b/static/partials/landing.html
@@ -61,8 +61,8 @@
         <div ng-show="!user.anonymous" class="user-welcome">
           <img class="gravatar" src="//www.gravatar.com/avatar/{{ user.gravatar }}?s=128&d=identicon" />
           <div class="sub-message">Welcome <b>{{ user.username }}</b>!</div>
-          <button ng-show="myrepos" class="btn btn-primary" ng-click="browseRepos()">Browse all repositories</button>
-          <button ng-show="myrepos" class="btn btn-success" ng-click="createRepo()">Create a new repository</button>
+          <a ng-show="myrepos" class="btn btn-primary" href="/repository/">Browse all repositories</a>
+          <a ng-show="myrepos" class="btn btn-success" href="/new/">Create a new repository</a>
         </div>
       </div> <!-- col -->
     </div> <!-- row -->
diff --git a/static/partials/v1-page.html b/static/partials/v1-page.html
index 821654fdd..e81c3d598 100644
--- a/static/partials/v1-page.html
+++ b/static/partials/v1-page.html
@@ -3,7 +3,7 @@
     <h3>Welcome <b>{{ user.username }}</b>. Your account is fully activated!</h3>
 
     <div style="margin-top: 20px;">
-      <button class="btn btn-lg btn-primary" ng-click="browseRepos()">Browse all repositories</button>
+      <a class="btn btn-lg btn-primary" hred="/repository/">Browse all repositories</a>
     </div>
   </div>
   <div ng-show="!user.anonymous && !user.verified">
diff --git a/static/partials/view-repo.html b/static/partials/view-repo.html
index a10c609a3..b2293d2e4 100644
--- a/static/partials/view-repo.html
+++ b/static/partials/view-repo.html
@@ -75,7 +75,7 @@
           <div class="panel panel-default">
             <div class="panel-heading">
               <!-- Tag dropdown -->
-              <span class="tag-dropdown dropdown" title="Tags">
+              <div class="tag-dropdown dropdown" title="Tags">
                 <i class="fa fa-tag"><span class="tag-count">{{getTagCount(repo)}}</span></i>
                 <a href="javascript:void(0)" class="dropdown-toggle" data-toggle="dropdown">{{currentTag.name}} <b class="caret"></b></a>
                 <ul class="dropdown-menu">
@@ -83,7 +83,7 @@
                     <a href="javascript:void(0)" ng-click="setTag(tag.name)">{{tag.name}}</a>
                   </li>
                 </ul>
-              </span>
+              </div>
               <span class="right-title">Tags</span>
               
             </div>
@@ -103,7 +103,7 @@
          <div class="panel panel-default">
            <div class="panel-heading">
              <!-- Image dropdown -->
-              <span class="tag-dropdown dropdown" title="Images">
+              <div class="tag-dropdown dropdown" title="Images">
                 <i class="fa fa-archive"><span class="tag-count">{{imageHistory.length}}</span></i>
                 <a href="javascript:void(0)" class="dropdown-toggle" data-toggle="dropdown">{{currentImage.id.substr(0, 12)}} <b class="caret"></b></a>
                 <ul class="dropdown-menu">
@@ -111,7 +111,7 @@
                     <a href="javascript:void(0)" ng-click="setImage(image)">{{image.id.substr(0, 12)}}</a>
                   </li>
                 </ul>
-              </span>
+              </div>
               <span class="right-title">Image</span>
             </div>