From a37978c971468a44123809817fff13ffc4bf3f2b Mon Sep 17 00:00:00 2001 From: Jake Moshenko Date: Mon, 2 Mar 2015 15:38:03 -0500 Subject: [PATCH] Move the user creation feature flag check to the user creation path of the user login post method. --- endpoints/index.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/endpoints/index.py b/endpoints/index.py index ca4b73362..74711986b 100644 --- a/endpoints/index.py +++ b/endpoints/index.py @@ -75,9 +75,6 @@ def generate_headers(scope=GrantType.READ_REPOSITORY): @index.route('/users', methods=['POST']) @index.route('/users/', methods=['POST']) def create_user(): - if not features.USER_CREATION: - abort(400, 'User creation is disabled. Please speak to your administrator.') - user_data = request.get_json() if not user_data or not 'username' in user_data: abort(400, 'Missing username') @@ -126,6 +123,9 @@ def create_user(): abort(400, 'Invalid password.', issue='login-failure') + elif not features.USER_CREATION: + abort(400, 'User creation is disabled. Please speak to your administrator.') + else: # New user case logger.debug('Creating user')