From 427ffea6b769545d3b29d41c8d47b6e579540c90 Mon Sep 17 00:00:00 2001 From: yackob03 Date: Tue, 5 Nov 2013 15:50:56 -0500 Subject: [PATCH 1/2] Fill in the remove team methods. --- data/model.py | 16 ++++++++++++---- endpoints/api.py | 6 +++--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/data/model.py b/data/model.py index 864ce1e2a..a10a560fc 100644 --- a/data/model.py +++ b/data/model.py @@ -112,9 +112,17 @@ def create_team(name, org, team_role_name, description=''): description=description) -def remove_team(name, org): - # TODO: have code to remove the team, and all its repo permissions, etc. - pass +def remove_team(org_name, team_name): + found = list(Team.select().join(User).where(User.organization == True, + User.username == org_name, + Team.name == team_name)) + if not found: + raise InvalidTeamException('Team named: %s is not a team in org: %s' % + (team_name, org_name)) + + team = found[0] + team.delete_instance(recursive=True, delete_nullable=True) + def add_user_to_team(user, team): return TeamMember.create(user=user, team=team) @@ -207,7 +215,7 @@ def validate_reset_code(code): def get_user(username): try: - return User.get(User.username == username) + return User.get(User.username == username, User.organization == False) except User.DoesNotExist: return None diff --git a/endpoints/api.py b/endpoints/api.py index 2e5ff3b21..b5db0d544 100644 --- a/endpoints/api.py +++ b/endpoints/api.py @@ -346,9 +346,9 @@ def update_organization_team(orgname, teamname): @app.route('/api/organization//team/', methods=['DELETE']) def delete_organization_team(orgname, teamname): - edit_permission = AdministerOrganizationPermission(orgname) - if edit_permission.can(): - model.remove_team(teamname, orgname) + permission = AdministerOrganizationPermission(orgname) + if permission.can(): + model.remove_team(orgname, teamname) return make_response('Deleted', 204) abort(403) From 5088fc9948b0bf6e2e9fba4611181607965aa5f6 Mon Sep 17 00:00:00 2001 From: yackob03 Date: Tue, 5 Nov 2013 16:05:38 -0500 Subject: [PATCH 2/2] Improve the responsiveness of the org-view a bit. --- static/css/quay.css | 1 - static/partials/org-view.html | 14 +++++--------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/static/css/quay.css b/static/css/quay.css index 95cd591da..e23ece05e 100644 --- a/static/css/quay.css +++ b/static/css/quay.css @@ -1418,7 +1418,6 @@ p.editable:hover i { .org-view .header-col { color: #444; - padding-left: 30px; } .org-view .header-col dd { diff --git a/static/partials/org-view.html b/static/partials/org-view.html index cdf74e14d..8bae67fb0 100644 --- a/static/partials/org-view.html +++ b/static/partials/org-view.html @@ -9,9 +9,8 @@
-
-
-
+