From 1d593274dc394b5875cdda3f7531b4df9332757f Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Fri, 20 Oct 2017 14:03:51 -0400 Subject: [PATCH] Fix build links in notifications Fixes https://jira.prod.coreos.systems/browse/QS-33 --- notifications/notificationevent.py | 2 +- static/js/services/notification-service.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/notifications/notificationevent.py b/notifications/notificationevent.py index d7a321aaf..02578e1a6 100644 --- a/notifications/notificationevent.py +++ b/notifications/notificationevent.py @@ -337,7 +337,7 @@ class BuildFailureEvent(BaseBuildEvent): } } } - }, subpage='/build?current=%s' % build_uuid) + }, subpage='/build/%s' % build_uuid) def get_summary(self, event_data, notification_data): return 'Build failure ' + _build_summary(event_data) diff --git a/static/js/services/notification-service.js b/static/js/services/notification-service.js index 546700ad4..ab8a118c5 100644 --- a/static/js/services/notification-service.js +++ b/static/js/services/notification-service.js @@ -95,7 +95,7 @@ function($rootScope, $interval, UserService, ApiService, StringBuilderService, P 'level': 'info', 'message': 'A build has been queued for repository {repository}', 'page': function(metadata) { - return '/repository/' + metadata.repository + '/build?current=' + metadata.build_id; + return '/repository/' + metadata.repository + '/build/' + metadata.build_id; }, 'dismissable': true }, @@ -103,7 +103,7 @@ function($rootScope, $interval, UserService, ApiService, StringBuilderService, P 'level': 'info', 'message': 'A build has been started for repository {repository}', 'page': function(metadata) { - return '/repository/' + metadata.repository + '/build?current=' + metadata.build_id; + return '/repository/' + metadata.repository + '/build/' + metadata.build_id; }, 'dismissable': true }, @@ -111,7 +111,7 @@ function($rootScope, $interval, UserService, ApiService, StringBuilderService, P 'level': 'info', 'message': 'A build has succeeded for repository {repository}', 'page': function(metadata) { - return '/repository/' + metadata.repository + '/build?current=' + metadata.build_id; + return '/repository/' + metadata.repository + '/build/' + metadata.build_id; }, 'dismissable': true }, @@ -119,7 +119,7 @@ function($rootScope, $interval, UserService, ApiService, StringBuilderService, P 'level': 'error', 'message': 'A build has failed for repository {repository}', 'page': function(metadata) { - return '/repository/' + metadata.repository + '/build?current=' + metadata.build_id; + return '/repository/' + metadata.repository + '/build/' + metadata.build_id; }, 'dismissable': true }, @@ -127,7 +127,7 @@ function($rootScope, $interval, UserService, ApiService, StringBuilderService, P 'level': 'info', 'message': 'A build was cancelled for repository {repository}', 'page': function(metadata) { - return '/repository/' + metadata.repository + '/build?current=' + metadata.build_id; + return '/repository/' + metadata.repository + '/build/' + metadata.build_id; }, 'dismissable': true },