vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Better handling of defcon1

Browse source
This commit is contained in:
Joseph Schorr 2016-03-10 15:02:38 -05:00
parent 821b09daaf
commit a941b26a2d
7 changed files with 21 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
static/css/directives/ui/image-feature-view.css
View file

@ -113,3 +113,8 @@
.image-feature-view-element .vuln-summary i.fa {
margin-right: 6px;
}
.image-feature-view-element .defcon1 {
background-color: #FF8181;
color: white;
}

5
static/css/directives/ui/image-vulnerability-view.css
View file

@ -193,3 +193,8 @@
margin-left: 2px;
margin-right: 2px;
}
.image-vulnerability-view-element .defcon1 {
background-color: #FF8181;
color: white;
}

2
static/directives/image-feature-view.html
View file

@ -92,7 +92,7 @@
<td class="hidden-xs options-col"></td>
</thead>
<tbody ng-repeat="feature in orderedFeatures.visibleEntries" bindonce>
<tr>
<tr ng-class="feature.primarySeverity.index == 0 ? 'defcon1' : ''">
<td class="single-col">
<span bo-text="feature.name"></span>
</td>

2
static/directives/image-vulnerability-view.html
View file

@ -98,7 +98,7 @@
<td class="hidden-xs options-col"></td>
</thead>
<tbody ng-repeat="vuln in orderedVulnerabilities.visibleEntries" bindonce>
<tr>
<tr ng-class="vuln.severityInfo.index == 0 ? 'defcon1' : ''">
<td class="caret-col">
<span ng-click="toggleDetails(vuln)">
<i class="fa"

6
static/js/directives/ui/image-vulnerability-view.js
View file

@ -28,11 +28,15 @@ angular.module('quay').directive('imageVulnerabilityView', function () {
};
$scope.getDistro = function(vuln) {
if (vuln['severity'] == 'Defcon 1') {
return 'the Quay Engineering Team';
}
return vuln['namespace'].split(':', 1);
};
$scope.getSeverityTooltip = function(vuln) {
var distro = vuln['namespace'].split(':', 1);
var distro = $scope.getDistro(vuln);
if (vuln.scoreDivergence != 'adjusted-lower') {
return 'Marked with a ' + vuln['severity'] + ' severity by ' + distro;

2
static/js/services/image-metadata-service.js
View file

@ -47,7 +47,7 @@ angular.module('quay').factory('ImageMetadataService', ['UtilService', function(
metadataService.getDockerfileCommand = function(command) {
if (!command) { return ''; }
command = command.join(' ').split(' ')
command = command.join(' ').split(' ');
// ["/bin/sh", "-c", "#(nop)", "RUN", "foo"]
if (command[0] != '/bin/sh' || command[1] != '-c') { return ''; }

6
static/js/services/vulnerability-service.js
View file

@ -133,15 +133,15 @@ angular.module('quay').factory('VulnerabilityService', ['Config', 'ApiService',
};
// Save the highest vulnerability severity for this feature.
highestSeverityIndex = Math.min(severity['index'], highestSeverityIndex)
highestSeverityIndex = Math.min(severity['index'], highestSeverityIndex);
// Add the score and (if necessary) the fixable scores.
score += exponentialScore;
severityCountMap[severity['index']]++
severityCountMap[severity['index']]++;
vulnerabilities.push(vuln_object);
if (vuln.FixedBy) {
fixableCountMap[severity['index']]++
fixableCountMap[severity['index']]++;
fixableScore += exponentialScore;
fixable.push(vuln_object)
}