vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Clarify the health checking logic and remove the accidental inclusion of the override

Browse source
This commit is contained in:
Joseph Schorr 2014-11-02 15:42:59 -05:00
parent 98602a2d0c
commit aed7e67a17
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
health/healthcheck.py
View file

@ -49,8 +49,7 @@ class ProductionHealthCheck(HealthCheck):
def check_name(cls): def check_name(cls):
return 'ProductionHealthCheck' return 'ProductionHealthCheck'
def conduct_healthcheck(self, db_healthy, buildlogs_healthy): def conduct_healthcheck(self, db_healthy, buildlogs_healthy):
db_healthy = False
data = { data = {
'db_healthy': db_healthy, 'db_healthy': db_healthy,
'buildlogs_healthy': buildlogs_healthy 'buildlogs_healthy': buildlogs_healthy
@ -78,7 +77,8 @@ class ProductionHealthCheck(HealthCheck):
data['db_available_checked'] = True data['db_available_checked'] = True
data['db_available_status'] = is_rds_working data['db_available_status'] = is_rds_working
if is_rds_working: # If RDS is down, then we still report the machine as healthy, so that it can handle
return (data, True) # requests once RDS comes back up.
return (data, not is_rds_working)
return (data, db_healthy) return (data, db_healthy)