Fix off-by-one error in repo tags pagination

Fixes #1665
This commit is contained in:
Joseph Schorr 2016-08-02 14:17:33 -04:00
parent c3a401d960
commit b1b0da7afd
3 changed files with 50 additions and 16 deletions

View file

@ -203,12 +203,14 @@ def list_repository_tag_history(repo_obj, page=1, size=100, specific_tag=None):
.where(RepositoryTag.repository == repo_obj)
.where(RepositoryTag.hidden == False)
.order_by(RepositoryTag.lifetime_start_ts.desc(), RepositoryTag.name)
.paginate(page, size))
.limit(size + 1)
.offset(size * (page - 1)))
if specific_tag:
query = query.where(RepositoryTag.name == specific_tag)
return query
tags = list(query)
return tags[0:size], len(tags) > size
def revert_tag(repo_obj, tag_name, docker_image_id):