vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #3380 from quay/joseph.schorr/QUAY-1353/always-new-tag-manifest

Browse source 
Always create a new tag manifest row when backfilling in the old data model
This commit is contained in:
Joseph Schorr 2019-02-20 17:20:32 -05:00 committed by GitHub
commit b5a5ce7c43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
data/model/tag.py
View file

@ -727,30 +727,24 @@ def get_possibly_expired_tag(namespace, repo_name, tag_name):
Namespace.username == namespace)).get() Namespace.username == namespace)).get()
def associate_generated_tag_manifest_with_tag(tag, manifest, storage_id_map): def associate_generated_tag_manifest_with_tag(tag, manifest, storage_id_map):
try: oci_manifest = _populate_manifest_and_blobs(tag.repository, manifest, storage_id_map)
manifest = TagManifest.get(digest=manifest.digest)
manifest.tag = tag
manifest.save()
return manifest, False
except TagManifest.DoesNotExist:
oci_manifest = _populate_manifest_and_blobs(tag.repository, manifest, storage_id_map)
with db_transaction(): with db_transaction():
try: try:
(Tag (Tag
.select() .select()
.join(TagToRepositoryTag) .join(TagToRepositoryTag)
.where(TagToRepositoryTag.repository_tag == tag)).get() .where(TagToRepositoryTag.repository_tag == tag)).get()
except Tag.DoesNotExist: except Tag.DoesNotExist:
oci_tag = Tag.create(repository=tag.repository, manifest=oci_manifest, name=tag.name, oci_tag = Tag.create(repository=tag.repository, manifest=oci_manifest, name=tag.name,
reversion=tag.reversion, reversion=tag.reversion,
lifetime_start_ms=tag.lifetime_start_ts * 1000, lifetime_start_ms=tag.lifetime_start_ts * 1000,
lifetime_end_ms=(tag.lifetime_end_ts * 1000 lifetime_end_ms=(tag.lifetime_end_ts * 1000
if tag.lifetime_end_ts else None), if tag.lifetime_end_ts else None),
tag_kind=Tag.tag_kind.get_id('tag')) tag_kind=Tag.tag_kind.get_id('tag'))
TagToRepositoryTag.create(tag=oci_tag, repository_tag=tag, repository=tag.repository) TagToRepositoryTag.create(tag=oci_tag, repository_tag=tag, repository=tag.repository)
return _associate_manifest(tag, oci_manifest), True return _associate_manifest(tag, oci_manifest)
def _associate_manifest(tag, oci_manifest): def _associate_manifest(tag, oci_manifest):

4
data/registry_model/registry_pre_oci_model.py
View file

@ -482,8 +482,8 @@ class PreOCIModel(SharedModel, RegistryDataInterface):
blob_query = self._lookup_repo_storages_by_content_checksum(repo, manifest.checksums) blob_query = self._lookup_repo_storages_by_content_checksum(repo, manifest.checksums)
storage_map = {blob.content_checksum: blob.id for blob in blob_query} storage_map = {blob.content_checksum: blob.id for blob in blob_query}
try: try:
tag_manifest, _ = model.tag.associate_generated_tag_manifest_with_tag(tag_obj, manifest, tag_manifest = model.tag.associate_generated_tag_manifest_with_tag(tag_obj, manifest,
storage_map) storage_map)
assert tag_manifest assert tag_manifest
except IntegrityError: except IntegrityError:
tag_manifest = model.tag.get_tag_manifest(tag_obj) tag_manifest = model.tag.get_tag_manifest(tag_obj)