vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Allow build triggers to be invoked by any repo admin

Browse source 
Fixes #1079
This commit is contained in:
Joseph Schorr 2016-09-09 17:21:14 -04:00
parent 3f2447d831
commit bda0311dbe
2 changed files with 5 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
endpoints/api/build.py
View file

@ -19,7 +19,6 @@ from endpoints.exception import Unauthorized, NotFound, InvalidRequest
from endpoints.building import start_build, PreparedBuild
from data import database
from data import model
from auth.auth_context import get_authenticated_user
from auth.permissions import (ReadRepositoryPermission, ModifyRepositoryPermission,
AdministerRepositoryPermission, AdministerOrganizationPermission,
SuperUserPermission)
@ -58,14 +57,7 @@ def trigger_view(trigger, can_read=False, can_admin=False, for_build=False):
build_source = build_trigger.config.get('build_source')
repo_url = build_trigger.get_repository_url() if build_source else None
if can_admin:
can_read = True
is_connected_user = False
if (can_admin and get_authenticated_user() and
trigger.connected_user_id == get_authenticated_user().id):
is_connected_user = True
can_read = can_read or can_admin
trigger_data = {
'id': trigger.uuid,
@ -76,7 +68,7 @@ def trigger_view(trigger, can_read=False, can_admin=False, for_build=False):
'repository_url': repo_url if can_read else None,
'config': build_trigger.config if can_admin else {},
'can_invoke': is_connected_user,
'can_invoke': can_admin,
}
if not for_build and can_admin and trigger.pull_robot: