vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make sure all scope applies occur outside of the main digest loop

Browse source
This commit is contained in:
Joseph Schorr 2014-07-10 16:38:41 -04:00
parent c7cc3f72f8
commit bebb02c800
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
static/js/app.js
View file

@ -432,9 +432,11 @@ quayApp = angular.module('quay', quayDependencies, function($provide, cfpLoading
// If an error occurred, report it and done. // If an error occurred, report it and done.
if (ping < 0) { if (ping < 0) {
cached['pings'] = [-1]; cached['pings'] = [-1];
$scope.$apply(function() { setTimeout(function() {
callback(-1, false, -1); $scope.$apply(function() {
}); callback(-1, false, -1);
});
}, 0);
return; return;
} }
@ -447,9 +449,11 @@ quayApp = angular.module('quay', quayDependencies, function($provide, cfpLoading
} }
// Report the average ping. // Report the average ping.
$scope.$apply(function() { setTimeout(function() {
callback(Math.floor(sum / cached['pings'].length), true, cached['pings'].length); $scope.$apply(function() {
}); callback(Math.floor(sum / cached['pings'].length), true, cached['pings'].length);
});
}, 0);
// Schedule another check if we've done less than three. // Schedule another check if we've done less than three.
if (cached['pings'].length < 3) { if (cached['pings'].length < 3) {
@ -486,9 +490,11 @@ quayApp = angular.module('quay', quayDependencies, function($provide, cfpLoading
pingService.pingUrl = function($scope, url, callback) { pingService.pingUrl = function($scope, url, callback) {
if (pingCache[url]) { if (pingCache[url]) {
cached = pingCache[url]; cached = pingCache[url];
$scope.$apply(function() { setTimeout(function() {
callback(cached.result, cached.success); $scope.$apply(function() {
}); callback(cached.result, cached.success);
});
}, 0);
return; return;
} }