From e4ad25ea815b026d81c241445d8efdca7910c95c Mon Sep 17 00:00:00 2001
From: Joseph Schorr <josephschorr@users.noreply.github.com>
Date: Wed, 21 Sep 2016 14:23:32 -0400
Subject: [PATCH] Add repository list pagination

Also changes our binds to be bind-once, which should significantly reduce memory and increase performance for large lists

Fixes #1856
---
 static/css/core-ui.css                     | 14 +++++++--
 static/directives/repo-list-table.html     | 35 +++++++++++++++-------
 static/directives/repo-list-view.html      |  2 +-
 static/js/directives/ng-image-watch.js     |  8 +++--
 static/js/directives/ui/repo-list-table.js | 10 +++++--
 static/js/directives/ui/repo-list-view.js  |  6 ++++
 6 files changed, 55 insertions(+), 20 deletions(-)

diff --git a/static/css/core-ui.css b/static/css/core-ui.css
index 68b326c80..26fb1b5cf 100644
--- a/static/css/core-ui.css
+++ b/static/css/core-ui.css
@@ -1310,6 +1310,10 @@ a:focus {
   padding-left: 4px;
 }
 
+.co-top-bar {
+  height: 50px;
+}
+
 .co-check-bar .co-checked-actions .btn {
   margin-left: 6px;
 }
@@ -1318,21 +1322,25 @@ a:focus {
   margin-right: 4px;
 }
 
-.co-check-bar .co-filter-box {
+.co-check-bar .co-filter-box, .co-top-bar .co-filter-box {
   float: right;
 }
 
-.co-check-bar .co-filter-box .page-controls {
+.co-check-bar .co-filter-box .page-controls, .co-top-bar .co-filter-box .page-controls  {
   margin-right: 6px;
   margin-bottom: 6px;
 }
 
-.co-check-bar .co-filter-box input {
+.co-check-bar .co-filter-box input, .co-top-bar .co-filter-box input  {
   width: 300px;
   display: inline-block;
   vertical-align: middle;
 }
 
+.co-top-bar .co-filter-box input  {
+  vertical-align: top;
+}
+
 .empty {
   border-bottom: none !important;
 }
diff --git a/static/directives/repo-list-table.html b/static/directives/repo-list-table.html
index 4707551b8..e4a9bcd49 100644
--- a/static/directives/repo-list-table.html
+++ b/static/directives/repo-list-table.html
@@ -1,11 +1,24 @@
 <div class="repo-list-table-element">
   <div class="cor-loader" ng-if="isLoading"></div>
-  <div ng-if="orderedRepositories.entries.length == 0 && !isLoading">
+
+  <div class="co-top-bar">
+    <span class="co-filter-box">
+     <span class="page-controls" total-count="orderedRepositories.entries.length" current-page="options.page" page-size="reposPerPage"></span>
+     <input class="form-control" type="text" ng-model="options.filter" placeholder="Filter Repositories..." style="margin-right: 10px;">
+    </span>
+  </div>
+
+  <div ng-if="orderedRepositories.entries.length == 0 && !isLoading && !options.filter">
     <div class="empty-primary-msg" ng-if="namespaces.length != 1">You do not have any viewable repositories.</div>
     <div class="empty-primary-msg" ng-if="namespaces.length == 1">This namespace doesn't have any viewable repositories.</div>
     <div class="empty-secondary-msg">Either no repositories exist yet or you may not have permission to view any. If you have permission, try <a href="/new">creating a new repository</a>.</div>
   </div>
 
+  <div ng-if="orderedRepositories.entries.length == 0 && !isLoading && options.filter">
+    <div class="empty-primary-msg">No matching repositories</div>
+    <div class="empty-secondary-msg">There are not matching repositories for the entered filter</div>
+  </div>
+
   <table class="co-table" ng-if="orderedRepositories.entries.length && !isLoading">
    <thead>
     <td class="hidden-xs"
@@ -31,26 +44,26 @@
    </thead>
 
    <tbody>
-     <tr ng-repeat="repository in orderedRepositories.entries">
+     <tr ng-repeat="repository in orderedRepositories.entries | slice:(reposPerPage * options.page):(reposPerPage * (options.page + 1))">
        <td class="repo-name-icon">
-          <span class="avatar" size="24" data="getAvatarData(repository.namespace)"></span>
-          <a href="/repository/{{ repository.namespace }}/{{ repository.name }}">
-            <span class="namespace">{{ repository.namespace }}</span>
-            <span class="name">{{ repository.name }}</span>
+          <span class="avatar" size="24" data="::getAvatarData(repository.namespace)"></span>
+          <a href="/repository/{{ ::repository.namespace }}/{{ ::repository.name }}">
+            <span class="namespace">{{ ::repository.namespace }}</span>
+            <span class="name">{{ ::repository.name }}</span>
           </a>
         </td>
        <td class="last-modified">
-         <span ng-if="repository.last_modified">
-           {{ repository.last_modified * 1000 | amCalendar }}
+         <span ng-if="::repository.last_modified">
+           {{ ::repository.last_modified * 1000 | amCalendar }}
          </span>
-         <span class="empty" ng-if="!repository.last_modified">(Empty Repository)</span>
+         <span class="empty" ng-if="::!repository.last_modified">(Empty Repository)</span>
        </td>
        <td class="popularity hidden-xs">
-         <span class="strength-indicator" value="repository.popularity" maximum="maxPopularity"
+         <span class="strength-indicator" value="::repository.popularity" maximum="::maxPopularity"
                log-base="10"></span>
        </td>
        <td ng-show="loggedIn">
-        <span class="repo-star" repository="repository"
+        <span class="repo-star" repository="::repository"
               star-toggled="starToggled({'repository': repository})"></span>
        </td>
      </tr>
diff --git a/static/directives/repo-list-view.html b/static/directives/repo-list-view.html
index 6e85e828a..3e3271185 100644
--- a/static/directives/repo-list-view.html
+++ b/static/directives/repo-list-view.html
@@ -1,6 +1,6 @@
 <div class="repo-list-view-element">
   <!-- Toggle -->
-  <div class="repo-list-toggleb btn-group" ng-show="!loading">
+  <div class="repo-list-toggleb btn-group" ng-show="!loading && optionAllowed">
     <i class="btn btn-default fa fa-th-large" ng-class="!showAsList ? 'active' : ''"
        ng-click="setShowAsList(false)" title="Grid View" data-container="body" bs-tooltip></i>
     <i class="btn btn-default fa fa-th-list" ng-class="showAsList ? 'active' : ''"
diff --git a/static/js/directives/ng-image-watch.js b/static/js/directives/ng-image-watch.js
index 7b6cde7b7..e8790615e 100644
--- a/static/js/directives/ng-image-watch.js
+++ b/static/js/directives/ng-image-watch.js
@@ -8,11 +8,15 @@ angular.module('quay').directive('ngImageWatch', function ($parse) {
       var fn = $parse(attr['ngImageWatch']);
       return function(scope, element) {
         element.bind('error', function() {
-          fn(scope, {result: false});
+          scope.$apply(function() {
+            fn(scope, {result: false});
+          })
         });
 
         element.bind('load', function() {
-          fn(scope, {result: true});
+          scope.$apply(function() {
+            fn(scope, {result: true});
+          })
         });
       }
     }
diff --git a/static/js/directives/ui/repo-list-table.js b/static/js/directives/ui/repo-list-table.js
index f6d19eaad..f5b1e7b2c 100644
--- a/static/js/directives/ui/repo-list-table.js
+++ b/static/js/directives/ui/repo-list-table.js
@@ -16,19 +16,22 @@ angular.module('quay').directive('repoListTable', function () {
     controller: function($scope, $element, $filter, TableService, UserService) {
       $scope.repositories = null;
       $scope.orderedRepositories = [];
+      $scope.reposPerPage = 50;
 
       $scope.maxPopularity = 0;
       $scope.options = {
         'predicate': 'popularity',
         'reverse': false,
-        'filter': null
+        'filter': null,
+        'page': 0
       };
 
       var buildOrderedRepositories = function() {
         if (!$scope.repositories) { return; }
 
-        $scope.orderedRepositories = TableService.buildOrderedItems($scope.repositories, $scope.options,
-            [], ['last_modified_datetime', 'popularity'])
+        $scope.orderedRepositories = TableService.buildOrderedItems($scope.repositories,
+            $scope.options,
+            ['namespace', 'name'], ['last_modified_datetime', 'popularity'])
       };
 
       $scope.tablePredicateClass = function(name, predicate, reverse) {
@@ -70,6 +73,7 @@ angular.module('quay').directive('repoListTable', function () {
 
       $scope.$watch('options.predicate', buildOrderedRepositories);
       $scope.$watch('options.reverse', buildOrderedRepositories);
+      $scope.$watch('options.filter', buildOrderedRepositories);
 
       $scope.$watch('repositoriesResources', function(resources) {
         $scope.repositories = [];
diff --git a/static/js/directives/ui/repo-list-view.js b/static/js/directives/ui/repo-list-view.js
index 2a5733e5e..787740722 100644
--- a/static/js/directives/ui/repo-list-view.js
+++ b/static/js/directives/ui/repo-list-view.js
@@ -17,6 +17,7 @@ angular.module('quay').directive('repoListView', function () {
       $scope.resources = [];
       $scope.loading = true;
       $scope.showAsList = CookieService.get('quay.repoview') == 'list';
+      $scope.optionAllowed = true;
 
       $scope.$watch('namespaces', function(namespaces) {
         if (!namespaces) { return; }
@@ -31,6 +32,11 @@ angular.module('quay').directive('repoListView', function () {
             }
           }
         });
+
+        $scope.optionAllowed = $scope.resources.length <= 250;
+        if (!$scope.optionAllowed) {
+          $scope.showAsList = true;
+        }
       }, true);
 
       $scope.setShowAsList = function(value) {