address review comments

- more inline documentation
 - don't explicitly specify audience
 - approver is optional in `generate_key`
 - ADD -> RUN for better caching of jwtproxy
This commit is contained in:
Evan Cordell 2016-04-28 20:10:28 -05:00 committed by Jimmy Zelinskie
parent 9df650688b
commit c766727d1d
5 changed files with 41 additions and 11 deletions

View file

@ -6,7 +6,7 @@ from timeparse import ParseDatetime
import argparse
def generate_key(approver, service, name, expiration_date=None, notes=None):
def generate_key(service, name, approver=None, expiration_date=None, notes=None):
metadata = {
'created_by': 'CLI tool',
}