From c9812864be96d928ee602445835827ceb1ba4e12 Mon Sep 17 00:00:00 2001
From: Joseph Schorr <josephschorr@users.noreply.github.com>
Date: Thu, 26 Jan 2017 12:03:56 -0500
Subject: [PATCH] Small JS fixes for the PR

---
 static/directives/icon-image-view.html       | 2 +-
 static/js/directives/ui/icon-image-view.js   | 2 +-
 static/js/services/external-login-service.js | 5 ++---
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/static/directives/icon-image-view.html b/static/directives/icon-image-view.html
index c213782e4..13b6105da 100644
--- a/static/directives/icon-image-view.html
+++ b/static/directives/icon-image-view.html
@@ -1,4 +1,4 @@
 <span class="icon-image-view-element">
   <img ng-src="{{ value }}" ng-if="value.indexOf('http') == 0">
   <i class="fa" ng-class="value" ng-if="value.indexOf('http') < 0"></i>
-</span>
\ No newline at end of file
+</span>
diff --git a/static/js/directives/ui/icon-image-view.js b/static/js/directives/ui/icon-image-view.js
index 02fccd046..019f5ea38 100644
--- a/static/js/directives/ui/icon-image-view.js
+++ b/static/js/directives/ui/icon-image-view.js
@@ -15,4 +15,4 @@ angular.module('quay').directive('iconImageView', function () {
     }
   };
   return directiveDefinitionObject;
-});
\ No newline at end of file
+});
diff --git a/static/js/services/external-login-service.js b/static/js/services/external-login-service.js
index a911fd07a..4f83ea4a7 100644
--- a/static/js/services/external-login-service.js
+++ b/static/js/services/external-login-service.js
@@ -5,7 +5,7 @@ angular.module('quay').factory('ExternalLoginService', ['Features', 'Config', 'A
   function(Features, Config, ApiService) {
   var externalLoginService = {};
 
-  externalLoginService.EXTERNAL_LOGINS = window.__external_login;
+  externalLoginService.EXTERNAL_LOGINS = window.__external_login || [];
 
   externalLoginService.getLoginUrl = function(loginService, action, callback) {
     var errorDisplay = ApiService.errorDisplay('Could not load external login service ' +
@@ -31,8 +31,7 @@ angular.module('quay').factory('ExternalLoginService', ['Features', 'Config', 'A
 
   externalLoginService.getSingleSigninUrl = function(callback) {
     if (!externalLoginService.hasSingleSignin()) {
-      callback(null);
-      return;
+      return callback(null);
     }
 
     // If there is a single external login service and direct login is disabled,