Merge branch 'master' into bees

endpoints/api/__init__.py

@@ -28,8 +28,8 @@ api_bp = Blueprint('api', __name__)
 api = Api()
 api.init_app(api_bp)
 api.decorators = [csrf_protect,
-                  process_oauth,
-                  crossdomain(origin='*', headers=['Authorization', 'Content-Type'])]
+                  crossdomain(origin='*', headers=['Authorization', 'Content-Type']),
+                  process_oauth]
 
 
 class ApiException(Exception):
@@ -91,6 +91,7 @@ def handle_api_error(error):
   if error.error_type is not None:
     response.headers['WWW-Authenticate'] = ('Bearer error="%s" error_description="%s"' %
                                             (error.error_type, error.error_description))
+
   return response
 
 
@@ -195,6 +196,7 @@ def query_param(name, help_str, type=reqparse.text_type, default=None,
       'default': default,
       'choices': choices,
       'required': required,
+      'location': ('args')
     })
     return func
   return add_param

endpoints/api/image.py

@@ -76,7 +76,7 @@ class RepositoryImage(RepositoryParamResource):
   @nickname('getImage')
   def get(self, namespace, repository, image_id):
     """ Get the information available for the specified image. """
-    image = model.get_repo_image(namespace, repository, image_id)
+    image = model.get_repo_image_extended(namespace, repository, image_id)
     if not image:
       raise NotFound()
 
@@ -99,7 +99,7 @@ class RepositoryImageChanges(RepositoryParamResource):
   @nickname('getImageChanges')
   def get(self, namespace, repository, image_id):
     """ Get the list of changes for the specified image. """
-    image = model.get_repo_image(namespace, repository, image_id)
+    image = model.get_repo_image_extended(namespace, repository, image_id)
 
     if not image:
       raise NotFound()

endpoints/api/superuser.py

@@ -52,6 +52,25 @@ def user_view(user):
     'super_user': user.username in app.config['SUPER_USERS']
   }
 
+@resource('/v1/superuser/usage/')
+@internal_only
+@show_if(features.SUPER_USERS)
+class UsageInformation(ApiResource):
+  """ Resource for returning the usage information for enterprise customers. """
+  @require_fresh_login
+  @nickname('getSystemUsage')
+  def get(self):
+    """ Returns the number of repository handles currently held. """
+    if SuperUserPermission().can():
+      return {
+        'usage': model.get_repository_usage(),
+        'allowed': app.config.get('MAXIMUM_REPOSITORY_USAGE', 20)
+      }
+
+    abort(403)
+
+
+
 @resource('/v1/superuser/users/')
 @internal_only
 @show_if(features.SUPER_USERS)

endpoints/api/trigger.py

@@ -326,7 +326,7 @@ class BuildTriggerAnalyze(RepositoryParamResource):
       if not found_repository:
         return {
           'status': 'error',
-          'message': 'Repository "%s" was not found' % (base_image)
+          'message': 'Repository "%s" referenced by the Dockerfile was not found' % (base_image)
         }
 
       # If the repository is private and the user cannot see that repo, then
@@ -335,7 +335,7 @@ class BuildTriggerAnalyze(RepositoryParamResource):
       if found_repository.visibility.name != 'public' and not can_read:
         return {
           'status': 'error',
-          'message': 'Repository "%s" was not found' % (base_image)
+          'message': 'Repository "%s" referenced by the Dockerfile was not found' % (base_image)
         }
 
       # Check to see if the repository is public. If not, we suggest the
@@ -463,18 +463,18 @@ class BuildTriggerFieldValues(RepositoryParamResource):
   """ Custom verb to fetch a values list for a particular field name. """
   @require_repo_admin
   @nickname('listTriggerFieldValues')
-  def get(self, namespace, repository, trigger_uuid, field_name):
+  def post(self, namespace, repository, trigger_uuid, field_name):
     """ List the field values for a custom run field. """
     try:
       trigger = model.get_build_trigger(namespace, repository, trigger_uuid)
     except model.InvalidBuildTriggerException:
       raise NotFound()
 
+    config = request.get_json() or json.loads(trigger.config)
     user_permission = UserAdminPermission(trigger.connected_user.username)
     if user_permission.can():
       trigger_handler = BuildTriggerBase.get_trigger_for_service(trigger.service.name)
-      values = trigger_handler.list_field_values(trigger.auth_token, json.loads(trigger.config),
-                                                 field_name)
+      values = trigger_handler.list_field_values(trigger.auth_token, config, field_name)
 
       if values is None:
         raise NotFound()

endpoints/api/user.py

@@ -120,6 +120,10 @@ class User(ApiResource):
           'type': 'string',
           'description': 'The user\'s email address',
         },
+        'invite_code': {
+          'type': 'string',
+          'description': 'The optional invite code'
+        }
       }
     },
     'UpdateUser': {
@@ -239,15 +243,12 @@ class User(ApiResource):
 
   @show_if(features.USER_CREATION)
   @nickname('createNewUser')
-  @parse_args
-  @query_param('inviteCode', 'Invitation code given for creating the user.', type=str,
-               default='')
   @internal_only
   @validate_json_request('NewUser')
-  def post(self, args):
+  def post(self):
     """ Create a new user. """
     user_data = request.get_json()
-    invite_code = args['inviteCode']
+    invite_code = user_data.get('invite_code', '')
 
     existing_user = model.get_user(user_data['username'])
     if existing_user: