Merge pull request #1754 from coreos-inc/team-add-perms

Better UI and permissions handling for robots and teams

test/test_api_security.py

@@ -10,7 +10,8 @@ from data import model
 from initdb import setup_database_for_testing, finished_database_for_testing
 from endpoints.api import api_bp, api
 
-from endpoints.api.team import TeamMember, TeamMemberList, OrganizationTeam, TeamMemberInvite
+from endpoints.api.team import (TeamMember, TeamMemberList, OrganizationTeam, TeamMemberInvite,
+                                TeamPermissions)
 from endpoints.api.tag import RepositoryTagImages, RepositoryTag, ListRepositoryTags, RevertTag
 from endpoints.api.search import EntitySearch
 from endpoints.api.image import RepositoryImage, RepositoryImageList
@@ -679,6 +680,24 @@ class TestTeamMemberBuynlargeDevtableOwners(ApiTestCase):
     self._run_test('DELETE', 400, 'devtable', None)
 
 
+class TestTeamPermissionsBuynlarge(ApiTestCase):
+  def setUp(self):
+    ApiTestCase.setUp(self)
+    self._set_url(TeamPermissions, orgname="buynlarge", teamname="readers")
+
+  def test_get_anonymous(self):
+    self._run_test('GET', 401, None, None)
+
+  def test_get_freshuser(self):
+    self._run_test('GET', 403, 'freshuser', None)
+
+  def test_get_reader(self):
+    self._run_test('GET', 403, 'reader', None)
+
+  def test_get_devtable(self):
+    self._run_test('GET', 200, 'devtable', None)
+
+
 class TestTeamMemberListBuynlargeReaders(ApiTestCase):
   def setUp(self):
     ApiTestCase.setUp(self)

test/test_api_usage.py

@@ -28,7 +28,8 @@ from data import database, model
 from data.database import RepositoryActionCount, Repository as RepositoryTable
 from test.helpers import assert_action_logged
 
-from endpoints.api.team import TeamMember, TeamMemberList, TeamMemberInvite, OrganizationTeam
+from endpoints.api.team import (TeamMember, TeamMemberList, TeamMemberInvite, OrganizationTeam,
+                                TeamPermissions)
 from endpoints.api.tag import RepositoryTagImages, RepositoryTag, RevertTag, ListRepositoryTags
 from endpoints.api.search import EntitySearch, ConductSearch
 from endpoints.api.image import RepositoryImage, RepositoryImageList
@@ -1158,6 +1159,16 @@ class TestDeleteOrganizationTeam(ApiTestCase):
     self.assertEquals(msg, data['message'])
 
 
+class TestTeamPermissions(ApiTestCase):
+  def test_team_permissions(self):
+    self.login(ADMIN_ACCESS_USER)
+
+    resp = self.getJsonResponse(TeamPermissions,
+                                params=dict(orgname=ORGANIZATION, teamname='readers'))
+
+    self.assertEquals(1, len(resp['permissions']))
+
+
 class TestGetOrganizationTeamMembers(ApiTestCase):
   def test_invalidteam(self):
     self.login(ADMIN_ACCESS_USER)