Add unit testing of custom trigger handler

This commit is contained in:
Joseph Schorr 2017-02-13 13:22:59 -05:00
parent a5fc7cba5f
commit cfe231f618
2 changed files with 56 additions and 5 deletions

View file

@ -16,9 +16,6 @@ from buildtrigger.bitbuckethandler import (BITBUCKET_WEBHOOK_PAYLOAD_SCHEMA as b
from buildtrigger.githubhandler import (GITHUB_WEBHOOK_PAYLOAD_SCHEMA as gh_schema,
get_transformed_webhook_payload as gh_payload)
from buildtrigger.bitbuckethandler import (BITBUCKET_WEBHOOK_PAYLOAD_SCHEMA as bb_schema,
get_transformed_webhook_payload as bb_payload)
from buildtrigger.gitlabhandler import (GITLAB_WEBHOOK_PAYLOAD_SCHEMA as gl_schema,
get_transformed_webhook_payload as gl_payload)
@ -162,7 +159,7 @@ class CustomBuildTrigger(BuildTriggerHandler):
def handle_trigger_request(self, request):
payload = request.data
if not payload:
raise InvalidPayloadException()
raise InvalidPayloadException('Missing expected payload')
logger.debug('Payload %s', payload)
@ -186,7 +183,10 @@ class CustomBuildTrigger(BuildTriggerHandler):
'git_url': config['build_source'],
}
return self.prepare_build(metadata, is_manual=True)
try:
return self.prepare_build(metadata, is_manual=True)
except ValidationError as ve:
raise TriggerStartException(ve.message)
def activate(self, standard_webhook_url):
config = self.config