Get build preparation working for bitbucket and do a lot of code cleanup around this process across all the triggers. Note: tests are not yet updated.

endpoints/api/build.py

@@ -10,7 +10,7 @@ from endpoints.api import (RepositoryParamResource, parse_args, query_param, nic
                            require_repo_read, require_repo_write, validate_json_request,
                            ApiResource, internal_only, format_date, api, Unauthorized, NotFound,
                            path_param, InvalidRequest, require_repo_admin)
-from endpoints.common import start_build
+from endpoints.building import start_build, PreparedBuild
 from endpoints.trigger import BuildTriggerHandler
 from data import model, database
 from auth.auth_context import get_authenticated_user
@@ -191,8 +191,8 @@ class RepositoryBuildList(RepositoryParamResource):
         raise Unauthorized()
 
     # Check if the dockerfile resource has already been used. If so, then it
-    # can only be reused if the user has access to the repository for which it
-    # was used.
+    # can only be reused if the user has access to the repository in which the
+    # dockerfile was previously built.
     associated_repository = model.get_repository_for_resource(dockerfile_id)
     if associated_repository:
       if not ModifyRepositoryPermission(associated_repository.namespace_user.username,
@@ -201,11 +201,16 @@ class RepositoryBuildList(RepositoryParamResource):
 
     # Start the build.
     repo = model.get_repository(namespace, repository)
-    display_name = user_files.get_file_checksum(dockerfile_id)
 
-    build_request = start_build(repo, dockerfile_id, tags, display_name, subdir, True,
-                                pull_robot_name=pull_robot_name)
+    prepared = PreparedBuild()
+    prepared.build_name = user_files.get_file_checksum(dockerfile_id)
+    prepared.dockerfile_id = dockerfile_id
+    prepared.tags = tags
+    prepared.subdirectory = subdir
+    prepared.is_manual = True
+    prepared.metadata = {}
 
+    build_request = start_build(repo, prepared, pull_robot_name=pull_robot_name)
     resp = build_status_view(build_request, can_write=True)
     repo_string = '%s/%s' % (namespace, repository)
     headers = {