Get build preparation working for bitbucket and do a lot of code cleanup around this process across all the triggers. Note: tests are not yet updated.

endpoints/common.py

@@ -1,5 +1,4 @@
 import logging
-import urlparse
 import json
 import string
 import datetime
@@ -14,18 +13,15 @@ from flask.ext.principal import identity_changed
 from random import SystemRandom
 
 from data import model
-from data.database import db
-from app import app, oauth_apps, dockerfile_build_queue, LoginWrappedDBUser
+from app import app, oauth_apps, LoginWrappedDBUser
 
 from auth.permissions import QuayDeferredPermissionUser
 from auth import scopes
-from auth.auth_context import get_authenticated_user
 from endpoints.api.discovery import swagger_route_data
 from werkzeug.routing import BaseConverter
 from functools import wraps
 from config import getFrontendVisibleConfig
 from external_libraries import get_external_javascript, get_external_css
-from endpoints.notificationhelper import spawn_notification
 
 import features
 
@@ -210,75 +206,3 @@ def check_repository_usage(user_or_org, plan_found):
   else:
     model.delete_notifications_by_kind(user_or_org, 'over_private_usage')
 
-
-def start_build(repository, dockerfile_id, tags, build_name, subdir, manual,
-                trigger=None, pull_robot_name=None, trigger_metadata=None):
-  host = urlparse.urlparse(request.url).netloc
-  repo_path = '%s/%s/%s' % (host, repository.namespace_user.username, repository.name)
-
-  token = model.create_access_token(repository, 'write', kind='build-worker',
-                                    friendly_name='Repository Build Token')
-  logger.debug('Creating build %s with repo %s tags %s and dockerfile_id %s',
-               build_name, repo_path, tags, dockerfile_id)
-
-  job_config = {
-    'docker_tags': tags,
-    'registry': host,
-    'build_subdir': subdir,
-    'trigger_metadata': trigger_metadata or {},
-    'is_manual': manual,
-    'manual_user': get_authenticated_user().username if get_authenticated_user() else None
-  }
-
-  with app.config['DB_TRANSACTION_FACTORY'](db):
-    build_request = model.create_repository_build(repository, token, job_config,
-                                                  dockerfile_id, build_name,
-                                                  trigger, pull_robot_name=pull_robot_name)
-
-    json_data = json.dumps({
-      'build_uuid': build_request.uuid,
-      'pull_credentials': model.get_pull_credentials(pull_robot_name) if pull_robot_name else None
-    })
-
-    queue_id = dockerfile_build_queue.put([repository.namespace_user.username, repository.name],
-                                          json_data,
-                                          retries_remaining=3)
-
-    build_request.queue_id = queue_id
-    build_request.save()
-
-  # Add the build to the repo's log.
-  metadata = {
-    'repo': repository.name,
-    'namespace': repository.namespace_user.username,
-    'fileid': dockerfile_id,
-    'is_manual': manual,
-    'manual_user': get_authenticated_user().username if get_authenticated_user() else None
-  }
-
-  if trigger:
-    metadata['trigger_id'] = trigger.uuid
-    metadata['config'] = json.loads(trigger.config)
-    metadata['service'] = trigger.service.name
-
-  model.log_action('build_dockerfile', repository.namespace_user.username, ip=request.remote_addr,
-                   metadata=metadata, repository=repository)
-
-  # Add notifications for the build queue.
-  logger.debug('Adding notifications for repository')
-  event_data = {
-    'build_id': build_request.uuid,
-    'build_name': build_name,
-    'docker_tags': tags,
-    'is_manual': manual,
-    'manual_user': get_authenticated_user().username if get_authenticated_user() else None
-  }
-
-  if trigger:
-    event_data['trigger_id'] = trigger.uuid
-    event_data['trigger_kind'] = trigger.service.name
-
-  spawn_notification(repository, 'build_queued', event_data,
-                     subpage='build?current=%s' % build_request.uuid,
-                     pathargs=['build', build_request.uuid])
-  return build_request