Move tar filter to file, add tests for it

config_app/config_endpoints/api/tar_config_loader.py

@@ -5,10 +5,10 @@ import tarfile
 from flask import request, make_response, send_file
 
 from data.database import configure
-from util.config.validator import EXTRA_CA_DIRECTORY
 
 from config_app.c_app import app, config_provider
 from config_app.config_endpoints.api import resource, ApiResource, nickname
+from config_app.config_util.tar import tarinfo_filter_partial
 
 @resource('/v1/configapp/initialization')
 class ConfigInitialization(ApiResource):
@@ -17,7 +17,7 @@ class ConfigInitialization(ApiResource):
     """
 
     @nickname('scStartNewConfig')
-    def get(self):
+    def post(self):
         config_provider.new_config_dir()
 
         return make_response('OK')
@@ -37,22 +37,12 @@ class TarConfigLoader(ApiResource):
         # remove the initial trailing / from the prefix path, and add the last dir one
         tar_dir_prefix = config_path[1:] + '/'
 
-        def tarinfo_filter(tarinfo):
-            # remove leading directory info
-            tarinfo.name = tarinfo.name.replace(tar_dir_prefix, '')
-
-            # ignore any directory that isn't the specified extra ca one:
-            if tarinfo.isdir() and not tarinfo.name == EXTRA_CA_DIRECTORY:
-                return None
-
-            return tarinfo
-
         temp = tempfile.NamedTemporaryFile()
 
         tar = tarfile.open(temp.name, mode="w|gz")
 
         for name in os.listdir(config_path):
-            tar.add(os.path.join(config_path, name), filter=tarinfo_filter)
+            tar.add(os.path.join(config_path, name), filter=tarinfo_filter_partial(tar_dir_prefix))
 
         tar.close()