From dddab6005895a70c90d99b63f7e70abc3c8d57e4 Mon Sep 17 00:00:00 2001
From: Joseph Schorr <joseph.schorr@coreos.com>
Date: Thu, 9 Apr 2015 16:25:10 -0400
Subject: [PATCH] Better empty messages on billing, prototype and application
 managers. Also properly handles the 404 for the invoices manager.

---
 static/directives/application-manager.html  | 10 +++++++++-
 static/directives/billing-invoices.html     | 11 +++++++----
 static/directives/prototype-manager.html    |  9 ++++++++-
 static/js/directives/ui/billing-invoices.js |  3 +++
 4 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/static/directives/application-manager.html b/static/directives/application-manager.html
index fa6eacb85..57c8a111d 100644
--- a/static/directives/application-manager.html
+++ b/static/directives/application-manager.html
@@ -15,7 +15,15 @@
       The OAuth Applications panel allows organizations to define custom OAuth applications that can be used by internal or external customers to access <span class="registry-name"></span> data on behalf of the customers. More information about the  <span class="registry-name"></span> API can be found by contacting support.
     </div>
 
-    <table class="co-table">
+    <div class="empty" ng-if="!applications.length">
+      <div class="empty-primary-msg">No OAuth applications defined.</div>
+      <div class="empty-secondary-msg">
+        Click the "Create New Application" button above to create a new OAuth application under
+        this organization.
+      </div>
+    </div>
+
+    <table class="co-table" ng-show="applications.length">
       <thead>
         <td>Application Name</td>
         <td>Application URI</td>
diff --git a/static/directives/billing-invoices.html b/static/directives/billing-invoices.html
index e4cf9cfe1..802abc358 100644
--- a/static/directives/billing-invoices.html
+++ b/static/directives/billing-invoices.html
@@ -1,11 +1,14 @@
 <div class="billing-invoices-element">
   <div class="cor-loader" ng-show="loading"></div>
 
-  <div ng-show="!loading && !invoices">
-    No invoices have been created
-  </div>
+   <div class="empty" ng-if="!loading && !invoices.length">
+      <div class="empty-primary-msg">No billing invoices found.</div>
+      <div class="empty-secondary-msg">
+        This account has not been billed by <span class="registry-name"></span>.
+      </div>
+    </div>
 
-  <div ng-show="!loading && invoices">
+  <div ng-show="!loading && invoices.length">
     <table class="co-table">
       <thead>
         <td>Billing Date/Time</td>
diff --git a/static/directives/prototype-manager.html b/static/directives/prototype-manager.html
index 639285224..7eebba032 100644
--- a/static/directives/prototype-manager.html
+++ b/static/directives/prototype-manager.html
@@ -19,7 +19,14 @@
       existing repositories.
     </div>
 
-    <table class="co-table">
+    <div class="empty" ng-if="!prototypes.length">
+      <div class="empty-primary-msg">No default permissions defined.</div>
+      <div class="empty-secondary-msg">
+        Click the "Create Default Permission" button above to create a new default permission.
+      </div>
+    </div>
+
+    <table class="co-table" ng-show="prototypes.length">
       <thead>
         <td>
           <span class="context-tooltip"
diff --git a/static/js/directives/ui/billing-invoices.js b/static/js/directives/ui/billing-invoices.js
index e2943a575..ad6696621 100644
--- a/static/js/directives/ui/billing-invoices.js
+++ b/static/js/directives/ui/billing-invoices.js
@@ -30,6 +30,9 @@ angular.module('quay').directive('billingInvoices', function () {
         ApiService.listInvoices($scope.organization).then(function(resp) {
           $scope.invoices = resp.invoices;
           $scope.loading = false;
+        }, function() {
+          $scope.invoices = [];
+          $scope.loading = false;
         });
       };