vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

triggers: gen ssh keypair outside of activate()

Browse source 
This keeps the private key from ever being exposed to the client.
This commit is contained in:
Jimmy Zelinskie 2015-03-19 14:31:01 -04:00
parent 93a9e9d01a
commit e6a7156657
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
endpoints/trigger.py
View file

@ -525,9 +525,7 @@ class GitHubBuildTrigger(BuildTrigger):
msg = 'Unable to find GitHub repository for source: %s' % new_build_source
raise TriggerActivationException(msg)
# Generate an SSH keypair and add the public key to the repository.
# TODO(jzelinskie): don't put this in the config! it's not secure!
config['public_key'], config['private_key'] = generate_ssh_keypair()
# Add a deploy key to the GitHub repository.
try:
deploy_key = gh_repo.create_key('Quay.io Builder', config['public_key'])
config['deploy_key_id'] = deploy_key.id