vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #3409 from KeyboardNerd/xss

Browse source 
Fix XSS injection when changing service key friendly name
This commit is contained in:
Sida Chen 2019-03-12 18:26:58 -04:00 • committed by GitHub
commit e7b89f8ab3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
static/js/directives/ui/service-keys-manager.js
View file

@ -11,7 +11,7 @@ angular.module('quay').directive('serviceKeysManager', function () {
scope: { scope: {
'isEnabled': '=isEnabled' 'isEnabled': '=isEnabled'
}, },
controller: function($scope, $element, ApiService, TableService, UIService) { controller: function($scope, $element, $sanitize, ApiService, TableService, UIService) {
$scope.options = { $scope.options = {
'filter': null, 'filter': null,
'predicate': 'expiration_datetime', 'predicate': 'expiration_datetime',
@ -98,7 +98,7 @@ angular.module('quay').directive('serviceKeysManager', function () {
$scope.showChangeName = function(key) { $scope.showChangeName = function(key) {
bootbox.prompt({ bootbox.prompt({
'size': 'small', 'size': 'small',
'title': 'Enter a friendly name for key ' + $scope.getKeyTitle(key), 'title': 'Enter a friendly name for key ' + $sanitize($scope.getKeyTitle(key)),
'value': key.name || '', 'value': key.name || '',
'callback': function(value) { 'callback': function(value) {
if (value != null) { if (value != null) {