Phase 4 of the namespace to user migration: actually remove the column from the db and remove the dependence on serialized namespaces in the workers and queues

data/model/legacy.py

@@ -592,6 +592,13 @@ def get_user_by_id(user_db_id):
     return None
 
 
+def get_namespace_by_user_id(namespace_user_db_id):
+  try:
+    return User.get(User.id == namespace_user_db_id, User.robot == False).username
+  except User.DoesNotExist:
+    raise InvalidUsernameException('User with id does not exist: %s' % namespace_user_db_id)
+
+
 def get_user_or_org_by_customer_id(customer_id):
   try:
     return User.get(User.stripe_id == customer_id)
@@ -858,6 +865,15 @@ def change_password(user, new_password):
   delete_notifications_by_kind(user, 'password_required')
 
 
+def change_username(user, new_username):
+  (username_valid, username_issue) = validate_username(new_username)
+  if not username_valid:
+    raise InvalidUsernameException('Invalid username %s: %s' % (new_username, username_issue))
+
+  user.username = new_username
+  user.save()
+
+
 def change_invoice_email(user, invoice_email):
   user.invoice_email = invoice_email
   user.save()
@@ -1676,10 +1692,21 @@ def load_token_data(code):
     raise InvalidTokenException('Invalid delegate token code: %s' % code)
 
 
-def get_repository_build(namespace_name, repository_name, build_uuid):
+def _get_build_base_query():
+  return (RepositoryBuild
+          .select(RepositoryBuild, RepositoryBuildTrigger, BuildTriggerService, Repository,
+                  Namespace)
+          .join(Repository)
+          .join(Namespace, on=(Repository.namespace_user == Namespace.id))
+          .switch(RepositoryBuild)
+          .join(RepositoryBuildTrigger, JOIN_LEFT_OUTER)
+          .join(BuildTriggerService, JOIN_LEFT_OUTER)
+          .order_by(RepositoryBuild.started.desc()))
+
+
+def get_repository_build(build_uuid):
   try:
-    query = list_repository_builds(namespace_name, repository_name, 1)
-    return query.where(RepositoryBuild.uuid == build_uuid).get()
+    return _get_build_base_query().where(RepositoryBuild.uuid == build_uuid).get()
 
   except RepositoryBuild.DoesNotExist:
     msg = 'Unable to locate a build by id: %s' % build_uuid
@@ -1688,15 +1715,8 @@ def get_repository_build(namespace_name, repository_name, build_uuid):
 
 def list_repository_builds(namespace_name, repository_name, limit,
                            include_inactive=True):
-  query = (RepositoryBuild
-           .select(RepositoryBuild, RepositoryBuildTrigger, BuildTriggerService)
-           .join(Repository)
-           .join(Namespace, on=(Repository.namespace_user == Namespace.id))
-           .switch(RepositoryBuild)
-           .join(RepositoryBuildTrigger, JOIN_LEFT_OUTER)
-           .join(BuildTriggerService, JOIN_LEFT_OUTER)
+  query = (_get_build_base_query()
            .where(Repository.name == repository_name, Namespace.username == namespace_name)
-           .order_by(RepositoryBuild.started.desc())
            .limit(limit))
 
   if not include_inactive:
@@ -1760,21 +1780,23 @@ def create_repo_notification(repo, event_name, method_name, config):
                                        config_json=json.dumps(config))
 
 
-def get_repo_notification(namespace_name, repository_name, uuid):
+def get_repo_notification(uuid):
   try:
     return (RepositoryNotification
             .select(RepositoryNotification, Repository, Namespace)
             .join(Repository)
             .join(Namespace, on=(Repository.namespace_user == Namespace.id))
-            .where(Namespace.username == namespace_name, Repository.name == repository_name,
-                   RepositoryNotification.uuid == uuid)
+            .where(RepositoryNotification.uuid == uuid)
             .get())
   except RepositoryNotification.DoesNotExist:
     raise InvalidNotificationException('No repository notification found with id: %s' % uuid)
 
 
 def delete_repo_notification(namespace_name, repository_name, uuid):
-  found = get_repo_notification(namespace_name, repository_name, uuid)
+  found = get_repo_notification(uuid)
+  if (found.repository.namespace_user.username != namespace_name or
+      found.repository.name != repository_name):
+    raise InvalidNotificationException('No repository notifiation found with id: %s' % uuid)
   found.delete_instance()
   return found