From ed82d65dd1f4ee4abb3cfb3cd73df895c347a2ed Mon Sep 17 00:00:00 2001
From: Joseph Schorr <jschorr@gmail.com>
Date: Wed, 18 Dec 2013 23:03:19 -0500
Subject: [PATCH] =?UTF-8?q?-=20Add=20API=20for=20returning=20the=20user?=
 =?UTF-8?q?=E2=80=99s=20used=20private=20repos=20and=20available=20private?=
 =?UTF-8?q?=20repos=20-=20Fix=20the=20same=20API=20for=20orgs=20-=20Change?=
 =?UTF-8?q?=20the=20chosen=20plan=20in=20the=20create=20repo=20view=20to?=
 =?UTF-8?q?=20use=20the=20API=20-=20Add=20an=20account=20indicator=20if=20?=
 =?UTF-8?q?the=20user=20is=20over=20their=20plan?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 endpoints/api.py                  | 26 +++++++++++++++++++++++++-
 static/directives/header-bar.html |  8 ++++++--
 static/js/app.js                  | 26 +++++++++++++++++++++-----
 static/js/controllers.js          | 19 +++++++++++++++----
 static/partials/new-repo.html     |  9 +++++++--
 5 files changed, 74 insertions(+), 14 deletions(-)

diff --git a/endpoints/api.py b/endpoints/api.py
index 2a18edf4c..95912b570 100644
--- a/endpoints/api.py
+++ b/endpoints/api.py
@@ -118,6 +118,26 @@ def get_logged_in_user():
   return jsonify(user_view(user))
 
 
+@app.route('/api/user/private', methods=['GET'])
+@api_login_required
+def get_user_private_count():
+  user = current_user.db_user()
+  private_repos = model.get_private_repo_count(user.username)
+  repos_allowed = 0
+
+  if user.stripe_id:
+    cus = stripe.Customer.retrieve(user.stripe_id)
+    if cus.subscription:
+      plan = get_plan(cus.subscription.plan.id)
+      if plan:
+        repos_allowed = plan['privateRepos']
+    
+  return jsonify({
+    'privateCount': private_repos,
+    'reposAllowed': repos_allowed
+  })
+
+
 @app.route('/api/user/convert', methods=['POST'])
 @api_login_required
 def convert_user_to_organization():
@@ -485,7 +505,11 @@ def get_organization_private_allowed(orgname):
     if organization.stripe_id:
       cus = stripe.Customer.retrieve(organization.stripe_id)
       if cus.subscription:
-        repos_allowed = get_plan(cus.subscription.plan.id)
+        repos_allowed = 0
+        plan = get_plan(cus.subscription.plan.id)
+        if plan:
+          repos_allowed = plan['privateRepos']
+              
         return jsonify({
           'privateAllowed': (private_repos < repos_allowed)
         })
diff --git a/static/directives/header-bar.html b/static/directives/header-bar.html
index 169c9bf06..6df3e1fe8 100644
--- a/static/directives/header-bar.html
+++ b/static/directives/header-bar.html
@@ -38,14 +38,18 @@
       <a href="javascript:void(0)" class="dropdown-toggle user-dropdown" data-toggle="dropdown">
         <img src="//www.gravatar.com/avatar/{{ user.gravatar }}?s=32&d=identicon" />
         {{ user.username }}
-        <span class="badge user-notification notification-animated" ng-show="user.askForPassword">1</span>
+        <span class="badge user-notification notification-animated" ng-show="user.askForPassword || overPlan">
+          {{ (user.askForPassword ? 1 : 0) + (overPlan ? 1 : 0) }}
+        </span>
         <b class="caret"></b>
       </a>
       <ul class="dropdown-menu">
         <li>
           <a href="/user/" target="{{ appLinkTarget() }}">
             Account Settings
-            <span class="badge user-notification" ng-show="user.askForPassword">1</span>
+            <span class="badge user-notification" ng-show="user.askForPassword || overPlan">
+              {{ (user.askForPassword ? 1 : 0) + (overPlan ? 1 : 0) }}
+            </span>
           </a>
         </li>
         <li><a ng-href="/organizations/" target="{{ appLinkTarget() }}">Organizations</a></li>
diff --git a/static/js/app.js b/static/js/app.js
index 234a361cd..072110bea 100644
--- a/static/js/app.js
+++ b/static/js/app.js
@@ -1493,10 +1493,26 @@ quayApp.directive('headerBar', function () {
     restrict: 'C',
     scope: {
     },
-    controller: function($scope, $element, $location, UserService, Restangular) {
-      $scope.$watch( function () { return UserService.currentUser(); }, function (currentUser) {
-        $scope.user = currentUser;
-      }, true);
+    controller: function($scope, $element, $location, UserService, PlanService, Restangular) {
+      $scope.overPlan = false;
+
+      var checkOverPlan = function() {
+        if ($scope.user.anonymous) {
+          $scope.overPlan = false;
+          return;
+        }
+
+        var checkPrivate = Restangular.one('user/private');
+        checkPrivate.customGET().then(function(resp) {
+          $scope.overPlan = resp.privateCount >= resp.reposAllowed;
+        });
+      };
+      
+      // Monitor any user changes and place the current user into the scope.
+      UserService.updateUserIn($scope, checkOverPlan);
+     
+      // Monitor any plan changes.
+      PlanService.registerListener(this, checkOverPlan);
         
       $scope.signout = function() {
         var signoutPost = Restangular.one('signout');
@@ -1511,7 +1527,7 @@ quayApp.directive('headerBar', function () {
             return "_self";
         }
         return "";
-      };
+      };     
     }
   };
   return directiveDefinitionObject;
diff --git a/static/js/controllers.js b/static/js/controllers.js
index 790355d80..0cb986e15 100644
--- a/static/js/controllers.js
+++ b/static/js/controllers.js
@@ -810,23 +810,34 @@ function NewRepoCtrl($scope, $location, $http, $timeout, UserService, Restangula
     
     var isUserNamespace = (namespace == $scope.user.username);
 
+    $scope.checkingPlan = true;
     $scope.planRequired = null;
     $scope.isUserNamespace = isUserNamespace;
 
     if (isUserNamespace) {
       // Load the user's subscription information in case they want to create a private
       // repository.
-      PlanService.getSubscription(null, subscribedToPlan, function() {
-        PlanService.getMinimumPlan(1, false, function(minimum) { $scope.planRequired = minimum; });
+      var checkPrivateAllowed = Restangular.one('user/private');
+      checkPrivateAllowed.get().then(function(resp) {
+        if (resp.privateCount + 1 > resp.reposAllowed) {
+          PlanService.getMinimumPlan(resp.privateCount + 1, false, function(minimum) {
+            $scope.planRequired = minimum;
+          });
+        }
+
+        $scope.checkingPlan = false;
+      }, function() {
+        $scope.planRequired = {};
+        $scope.checkingPlan = false;
       });
     } else {
-      $scope.planRequired = null;
-
       var checkPrivateAllowed = Restangular.one('organization/' + namespace  + '/private');
       checkPrivateAllowed.get().then(function(resp) {
         $scope.planRequired = resp.privateAllowed ? null : {};
+        $scope.checkingPlan = false;
       }, function() {
         $scope.planRequired = {};
+        $scope.checkingPlan = false;
       });
 
       // Auto-set to private repo.
diff --git a/static/partials/new-repo.html b/static/partials/new-repo.html
index 5f3ea1535..bafc2dbb1 100644
--- a/static/partials/new-repo.html
+++ b/static/partials/new-repo.html
@@ -74,12 +74,14 @@
         <!-- Payment -->
         <div class="required-plan" ng-show="repo.is_public == '0' && planRequired && isUserNamespace">
           <div class="alert alert-warning">
-          In order to make this repository private, you’ll need to upgrade your plan from <b>{{ subscribedPlan.title  }}</b> to <b>{{ planRequired.title  }}</b>. This will cost $<span>{{ planRequired.price / 100 }}</span>/month.
+          In order to make this repository private, you’ll need to upgrade your plan to <b>{{ planRequired.title  }}</b>. This will cost $<span>{{ planRequired.price / 100 }}</span>/month.
           </div>
           <a class="btn btn-primary" ng-click="upgradePlan()" ng-show="!planChanging">Upgrade now</a>
           <div class="quay-spinner" ng-show="planChanging"></div>
         </div>
 
+        <div class="quay-spinner" ng-show="repo.is_public == '0' && checkingPlan"></div>
+
         <div class="required-plan" ng-show="repo.is_public == '0' && planRequired && !isUserNamespace">
           <div class="alert alert-warning">
             This organization has reached its  private repository limit. Please contact your administrator.
@@ -114,7 +116,10 @@
   <div class="row">
     <div class="col-md-1"></div>
     <div class="col-md-8">
-      <button class="btn btn-large btn-success" type="submit" ng-disabled="newRepoForm.$invalid || (repo.is_public == '0' && planRequired)">Create Repository</button>
+      <button class="btn btn-large btn-success" type="submit"
+              ng-disabled="newRepoForm.$invalid || (repo.is_public == '0' && (planRequired || checkingPlan))">
+        Create Repository
+      </button>
     </div>
   </div>