vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Remove the HEAD check for a file being read in cloud storage

Browse source 
In addition to being unnecessary, it also causes read-after-write issues occasionally on S3
This commit is contained in:
Joseph Schorr 2019-02-18 14:27:28 -05:00
parent 15ec09cb58
commit f07d7e0a73
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
storage/cloud.py
View file

@ -114,9 +114,15 @@ class _CloudStorage(BaseStorageV2):
self._initialize_cloud_conn() self._initialize_cloud_conn()
path = self._init_path(path) path = self._init_path(path)
key = self._key_class(self._cloud_bucket, path) key = self._key_class(self._cloud_bucket, path)
if not key.exists(): try:
raise IOError('No such key: \'{0}\''.format(path)) return key.get_contents_as_string()
return key.get_contents_as_string() except S3ResponseError as s3r:
# Raise an IOError in case the key was not found, to maintain the current
# interface.
if s3r.error_code == 'NoSuchKey':
raise IOError('No such key: \'{0}\''.format(path))
raise
def put_content(self, path, content): def put_content(self, path, content):
self._initialize_cloud_conn() self._initialize_cloud_conn()