vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1001 from coreos-inc/builderexc

Browse source 
Change to only exception logging internal errors on builds
This commit is contained in:
josephschorr 2015-11-30 14:37:32 -05:00
commit faacbc5d05
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
buildman/component/buildcomponent.py
View file

@ -293,8 +293,6 @@ class BuildComponent(BaseComponent):
self._current_job.send_notification('build_success', image_id=kwargs.get('image_id')) self._current_job.send_notification('build_success', image_id=kwargs.get('image_id'))
except ApplicationError as aex: except ApplicationError as aex:
build_id = self._current_job.repo_build.uuid build_id = self._current_job.repo_build.uuid
logger.exception('Got remote exception for build: %s', build_id)
worker_error = WorkerError(aex.error, aex.kwargs.get('base_error')) worker_error = WorkerError(aex.error, aex.kwargs.get('base_error'))
# Write the error to the log. # Write the error to the log.
@ -308,8 +306,10 @@ class BuildComponent(BaseComponent):
# Mark the build as completed. # Mark the build as completed.
if worker_error.is_internal_error(): if worker_error.is_internal_error():
logger.exception('Got remote internal exception for build: %s', build_id)
trollius.async(self._build_finished(BuildJobResult.INCOMPLETE)) trollius.async(self._build_finished(BuildJobResult.INCOMPLETE))
else: else:
logger.debug('Got remote failure exception for build %s: %s', build_id, aex)
trollius.async(self._build_finished(BuildJobResult.ERROR)) trollius.async(self._build_finished(BuildJobResult.ERROR))
@trollius.coroutine @trollius.coroutine