vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
9193 commits 2 branches 62 tags 205 MiB
Commit graph

2258 commits

Author SHA1 Message Date
josephschorr
fd1237cff9
Merge pull request #2974 from coreos-inc/joseph.schorr/QS-118/manifest-write-query 
Audit the number of SQL queries we make in writing manifests, and significantly reduce in the common case
 2018-01-31 11:08:33 -05:00
Joseph Schorr
9e16a989f5 Audit the number of SQL queries we make in writing manifests, and significantly reduce in the common case 
Instead of 41 queries now for the simple manifest, we are down to 14.

The biggest changes:
  - Only synthesize the V1 image rows if we haven't already found them in the database
  - Thread the repository object through to the other model method calls, and use it instead of loading again and again
 2018-01-25 11:10:43 -05:00
Joseph Schorr
208dc38d25 Allow expired app specific tokens to be deleted 2018-01-23 11:40:51 -05:00
josephschorr
b29e8202e5
Merge pull request #2977 from coreos-inc/joseph.schorr/QS-121/gunicorn-health 
Add instance health checks for all gunicorn workers
 2018-01-16 11:31:22 -05:00
Joseph Schorr
e91b83e1be Add instance health checks for all gunicorn workers 
Fixes https://jira.coreos.com/browse/QS-121
 2018-01-16 11:29:40 -05:00
Joseph Schorr
a32edb646d Fix 500 exception when sending a non-string release name to appr 
Fixes https://jira.coreos.com/browse/QS-120
 2018-01-12 17:14:05 -05:00
Joseph Schorr
c887aa543b Change superuser API errors to be more descriptive 
Fixes https://jira.coreos.com/browse/QS-103
 2018-01-05 17:09:26 -05:00
josephschorr
13b738c43c
Merge pull request #2954 from coreos-inc/joseph.schorr/QS-102/user-api-filter 
Add ability to filter users list to enabled users
 2018-01-05 15:40:50 -05:00
josephschorr
5286fd63b0
Merge pull request #2953 from coreos-inc/joseph.schorr/QS-101/discovery-anon 
Allow anonymous access to the discovery endpoint
 2018-01-05 15:40:39 -05:00
josephschorr
d8fde005d8
Merge pull request #2961 from coreos-inc/joseph.schorr/QS-107/create-repo-opt 
Small optimizations around create repository code
 2018-01-05 15:40:30 -05:00
Joseph Schorr
888b564a9b Add a banner to the Quay UI when an app specific token is about to expire 2018-01-04 15:27:42 -05:00
Joseph Schorr
2214a2c7ad Disable fresh login check in auth engines that won't support it 2018-01-04 15:27:41 -05:00
Joseph Schorr
524d77f527 Add an AppSpecificAuthToken data model for app-specific auth tokens. These will be used for the Docker CLI in place of username+password 2018-01-04 15:27:41 -05:00
Joseph Schorr
1e1bec0afe Remove extra update call on create repo 2018-01-04 13:42:05 -05:00
Joseph Schorr
c1cff32c1e Fix log levels in registry 2018-01-04 13:07:11 -05:00
Joseph Schorr
f05982dc7c Fix app registry logging 2018-01-04 13:05:50 -05:00
Joseph Schorr
8e473b9779 Add filter for disabled users to superuser user list API 
Fixes https://jira.coreos.com/browse/QS-102
 2017-12-22 16:45:49 -05:00
Joseph Schorr
1d3a93efcb Linter fixes for superuser API file 2017-12-22 16:18:58 -05:00
Joseph Schorr
6b42e3e4ca Allow anonymous access to the discovery endpoint 
Fixes https://jira.coreos.com/browse/QS-101
 2017-12-22 16:13:23 -05:00
Joseph Schorr
11e3724919 Return an http 415 (manifest version not supported) for OCI manifest content types 
This was breaking skopeo, as it first tries to send the *OCI* manifest type, which we didn't say we didn't support, thus breaking the tool
 2017-12-20 11:02:34 -05:00
Joseph Schorr
9e16596854 Add a bunch of logging to the data model caching mechanism 
Should help us debug any potential issues
 2017-12-18 14:18:37 -05:00
Joseph Schorr
b2485934ed Enable caching of blobs in V2 registry protocol, to avoid DB connections after the cache has been loaded 
This should help for bursty pull traffic, as it will avoid DB connections on a huge % of requests
 2017-12-14 13:38:24 -05:00
Joseph Schorr
db6007cb37 Change v2 registry auth code to not hit the database when we know we have permissions loaded 
Avoids a DB call and, when used in conjunction with blob caching, will avoid a DB *connection*
 2017-12-14 13:37:31 -05:00
Joseph Schorr
51e67ab7f5 Fix get_blob_path to not make any database calls and add a test 
This will be supported by caching, hopefully removing the need to hit the database when the blob object is cached
 2017-12-13 16:27:46 -05:00
Joseph Schorr
a706d99849 Add additional logs and an additional test for verbs 2017-12-07 15:22:20 -05:00
josephschorr
6db2ecc19f
Merge pull request #2928 from coreos-inc/joseph.schorr/QS-74/fix-restart 
Have Quay lookup the sbin/my_init PID to kill
 2017-12-07 13:25:16 -05:00
Joseph Schorr
1d1c6f0606 Invalidate all session tokens when a user signs out 
Fixes https://jira.coreos.com/browse/QS-85
 2017-12-07 13:03:11 -05:00
josephschorr
d405f6f158
Merge pull request #2899 from coreos-inc/joseph.schorr/QS-36/appr-auth-improvement 
Allow app registry to use robots and tokens to login
 2017-12-06 15:04:22 -05:00
josephschorr
b9ad8bbb5d
Merge pull request #2934 from coreos-inc/joseph.schorr/QS-78/email-recovery 
Security fixes for password recovery
 2017-12-06 14:53:02 -05:00
Joseph Schorr
a204dc20fb Require CAPTCHA for password recovery 
https://jira.coreos.com/browse/QS-79
 2017-12-06 14:25:34 -05:00
josephschorr
8d7381336a
Merge pull request #2910 from coreos-inc/joseph.schorr/QS-58/oidc-auth-bug 
Don't add a "password required" notification for non-database auth via OIDC
 2017-12-06 14:19:49 -05:00
Joseph Schorr
927d469db0 In password recovery, don't reveal whether an e-mail address is valid (unless it is an org's e-mail address) 2017-12-06 14:07:38 -05:00
Joseph Schorr
3bf8973fd9 Change app registry to use the credentials verification system 
Allows for tokens, OAuth tokens and robot accounts to be used as well

Fixes https://jira.prod.coreos.systems/browse/QS-36
 2017-12-06 13:52:25 -05:00
Joseph Schorr
aa49b37ad2 Change Docker V1 index to use verify_credentials 2017-12-06 13:52:25 -05:00
Joseph Schorr
25248a8c35 Make sure to close the database connection before forking in verbs 
This prevents a bug with the postgres driver from breaking the verbs

Fixes https://jira.coreos.com/browse/QS-68
 2017-12-04 16:33:24 -05:00
Joseph Schorr
4db1615d94 Fix bugs in updateuser 
1) Also check for matching organization names
2) Ensure that errors don't leave the throbber
 2017-12-01 14:58:29 -05:00
Joseph Schorr
874a7b0c41 Have Quay lookup the sbin/my_init PID to kill 
We changed the entry point in Quay to be a shell script that calls `my_init`, which means the init no longer has PID 1. We therefore need to look up the correct PID to kill it.

Fixes https://jira.coreos.com/browse/QS-74
 2017-12-01 14:04:43 -05:00
Joseph Schorr
2ced523313 Add Explore tab and query-less searching 
Allows for exploration of all visible repositories, in paginated form.

This change also fixes the layout of the header on different viewport sizes to be consistently a single line in height.

Fixes https://jira.coreos.com/browse/QS-63
 2017-11-28 16:50:23 +02:00
Joseph Schorr
9b2fb46e34 Move recaptcha check after the username check 
Ensures that if someone chooses an existing username, they don't need to re-recaptcha

Fixes https://jira.coreos.com/browse/QS-65
 2017-11-27 16:59:42 +02:00
Joseph Schorr
503cff8f0c Don't add a "password required" notification for non-database auth via OIDC 2017-11-13 16:17:36 -05:00
Joseph Schorr
1b6ecb6c1c Fix bug in listing owned tags 
We were indexing into a map using the docker_image_id, but the ancestors use the *image id*. Also cleans up the code and adds some tests.

Fixes https://jira.prod.coreos.systems/browse/QS-55
 2017-11-09 16:21:40 -05:00
Joseph Schorr
f67e2baeba Fix verbs for recent storage change 
1) Initialize the storage class in verbs with the extra needed args
2) Make the CloudFrontedS3Storage resilient to those extra args being missing
 2017-10-07 00:17:10 -04:00
Joseph Schorr
2ce4e49711 Build job does not have a request context when calling get_file_url 
We therefore need to specify some sort of IP or get_file_url will attempt to get it from context
 2017-10-06 12:57:02 -04:00
josephschorr
3bef21253d Merge pull request #2695 from coreos-inc/oidc-internal-auth 
OIDC internal auth support
 2017-10-02 16:51:17 -04:00
josephschorr
491b9c8278 Merge pull request #2872 from coreos-inc/joseph.schorr/QS-12/fix-org-links 
Fix namespace links that end in slashes
 2017-09-29 13:03:10 -04:00
josephschorr
82e09d6f16 Merge pull request #2869 from coreos-inc/joseph.schorr/QS-2/cloudfront 
CloudFront redirect support
 2017-09-29 12:08:50 -04:00
Joseph Schorr
58e6a17373 Fix namespace links that end in slashes 2017-09-28 15:14:53 -04:00
Joseph Schorr
82ff85b125 Add ability for users to change their name and company information 2017-09-26 16:58:04 -04:00
Joseph Schorr
56fbbcf7cf Add request IP to get_direct_download_url method 2017-09-25 17:14:28 -04:00
Alec Merdler
ad61df66c5 Merge pull request #2846 from alecmerdler/QUAY-682 
Optimize Webpack JS Bundle Size
 2017-09-18 16:47:30 -04:00
Joseph Schorr
804d3c46c3 Add feature flag to allow users to be created only if invited to join a team 
Allows for open user creation, but only if extended an invitation by someone who already has access
 2017-09-14 16:28:39 -04:00
Joseph Schorr
c6aad5fef0 Add option to disable partial autocompletion of users 2017-09-12 15:55:37 -04:00
Joseph Schorr
adc70d2fe2 Add alias for callback path 2017-09-12 12:26:42 -04:00
Evan Cordell
1d246784dd Include invalid oidc token in the error message for debugging 2017-09-12 12:26:42 -04:00
Joseph Schorr
e724125459 Add support for using OIDC tokens via the Docker CLI 2017-09-12 12:23:22 -04:00
Joseph Schorr
e0820c6be5 Remove encoding of credentials in build trigger web hook 
This now breaks BitBucket
 2017-09-07 11:27:02 -04:00
Joseph Schorr
2fdc1be94b Remove duplicate orgs when using public namespaces 
Fixes https://coreosdev.atlassian.net/browse/QUAY-770
 2017-08-24 14:13:26 -04:00
Joseph Schorr
464bccb5a0 Fix permissions on accessing archived logs 2017-08-18 13:45:36 -04:00
josephschorr
46e1bd9c75 Merge pull request #2850 from coreos-inc/jpmc-features 
Features for JPMC
 2017-08-16 14:29:00 -04:00
Jimmy Zelinskie
9e09612851 Revert "Merge pull request #2844 from coreos-inc/alegrand/use_latest_appr_server_code" 
This reverts commit 646fafb2fd, reversing
changes made to 5c1b635439.
 2017-08-09 20:45:46 -04:00
Joseph Schorr
854155fe82 Fix missing to_dict and import in robots model 
Also adds a test to catch this issue
 2017-08-09 20:33:14 -04:00
Joseph Schorr
2184721d28 Fix recursion error in images API 
We only need parents for the root set of images
 2017-08-09 13:27:54 -04:00
Evan Cordell
cac0457540 fix misnamed key in permissions api 2017-08-09 08:37:59 -04:00
Antoine Legrand
646fafb2fd Merge pull request #2844 from coreos-inc/alegrand/use_latest_appr_server_code 
Migrate from cnr -> appr
 2017-08-09 00:01:25 +02:00
Joseph Schorr
57136eb343 Require CAPTCHA for creating new accounts via OAuth 
Plugs the remaining hole for bot-based account creation
 2017-08-08 15:23:57 -04:00
Antoine Legrand
6336a4a971 Migrate from cnr -> appr 2017-08-08 11:48:59 +02:00
Joseph Schorr
650dbe5f5b Add config to enable "public" namespaces 
These are namespaces that will be displayed in the repo list view, regardless of whether the user is a member.
 2017-08-07 15:59:06 -04:00
Joseph Schorr
dff4207a89 Add feature flag to enable viewing builds and build logs for public repos 2017-08-07 15:24:36 -04:00
Alec Merdler
6dae6c4f82 whitelisted moment.js locales to reduce bundle size 2017-08-02 15:46:14 -04:00
Alec Merdler
41c12c853c use Webpack code-splitting to dynamically import Highlight.js languages as they are detected by Showdown Markdown extension 2017-08-01 15:36:54 -04:00
Charlton Austin
0359ac8753 Merge pull request #2848 from charltonaustin/fix_bug_robot_stuffs 
fix(endpoints/api/robot.py): fix misnamed attribute
 2017-08-01 15:05:43 -04:00
Charlton Austin
36e58e3bd0 fix(endpoints/api/robot.py): fix missnamed attribute 
Issue:NA

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-08-01 14:43:20 -04:00
Charlton Austin
524af4331d Merge pull request #2847 from charltonaustin/fix_bug_superuser_panel 
fix(superuser_models_pre_oci): have None for approver
 2017-08-01 13:37:50 -04:00
josephschorr
83e9dfac7a Merge pull request #2817 from coreos-inc/joseph.schorr/QUAY-688/dex-fixes 
Dex Fixes
 2017-08-01 13:26:50 -04:00
Charlton Austin
f05e684b31 fix(superuser_models_pre_oci): have None for approver 
### Description of Changes

this fixes a null pointer exception

Issue: https://coreosdev.atlassian.net/browse/QUAY-fix_bug_superuser_panel

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-08-01 13:09:41 -04:00
Charlton Austin
044036ff4d Merge pull request #2843 from charltonaustin/create_data_interface_for_subsystem_api/superuser.py_750 
Create data interface for subsystem api/superuser.py 750
 2017-08-01 12:03:19 -04:00
Evan Cordell
e407bc1441 Merge pull request #2806 from ecordell/QUAY-643/api-permission-v22 
Add data interface for api-permissions for v2-2
 2017-08-01 11:56:40 -04:00
Evan Cordell
66dc093639 Convert RepositoryUserTransitivePermission security tests to pytest 2017-08-01 11:34:31 -04:00
Charlton Austin
6c29ec873a refactor(endpoints/api/superuser*): refactored code behind db model 
this moves all the db model code behind an interface in prep for v2-2

Issue: https://coreosdev.atlassian.net/browse/QUAY-750

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-08-01 11:27:55 -04:00
Evan Cordell
37ebfd9ab5 Merge pull request #2808 from ecordell/QUAY-647/api-globalmessages-v22 
Add data interface for globalmessages API
 2017-08-01 10:59:35 -04:00
Charlton Austin
3688b6a8df style(endpoints/api/suconfig_models_interface.py): formatted file 
### Description of Changes

Issue: https://coreosdev.atlassian.net/browse/QUAY-750

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-08-01 09:39:17 -04:00
Charlton Austin
d55397e851 Merge pull request #2820 from charltonaustin/create_data_interface_for_subsystem_api/robot.py_630 
refactor(endpoints/api/robot*): adding in database interface
 2017-08-01 09:37:09 -04:00
Evan Cordell
4734cc90b4 Merge pull request #2809 from ecordell/QUAY-649/api-manifest-v22 
Add a data interface for manifest labels API
 2017-08-01 09:34:10 -04:00
josephschorr
0ae767d506 Merge pull request #2811 from coreos-inc/joseph.schorr/QUAY-631/repotoken-data-interface 
Change repotoken to use a data interface
 2017-07-31 18:02:12 -04:00
josephschorr
004fb88726 Merge pull request #2815 from coreos-inc/joseph.schorr/QUAY-650/image-api-data-interface 
Change Image API to use a data interface
 2017-07-31 18:01:55 -04:00
Joseph Schorr
9676d7d8c7 Make downstream issues show their error in the UI 2017-07-31 17:07:22 -04:00
Evan Cordell
6528c1f3bc Adds docstrings for permission api data interface 2017-07-31 15:46:13 -04:00
Evan Cordell
a68ec6966e Add data interface for api-permissions for v2-2 2017-07-31 15:46:13 -04:00
Evan Cordell
c92b566427 Add doc comments to data interface for manifest labels 2017-07-31 15:45:52 -04:00
Evan Cordell
af27a1b6dc Add a data interface for manifest labels API 2017-07-31 15:45:52 -04:00
Evan Cordell
0d239e08c2 Add docstrings to globalmessages data interface 2017-07-31 15:44:54 -04:00
Evan Cordell
4ca6c37e54 Add data interface for globalmessages API 2017-07-31 15:44:54 -04:00
Jimmy Zelinskie
fe6760749a Merge pull request #2826 from jzelinskie/appr-v22 
endpoints.appr: move to new v22 format
 2017-07-31 07:36:40 -07:00
Joseph Schorr
8ab600707c Change repotoken to use a data interface 2017-07-28 15:51:49 -04:00
Charlton Austin
39196b6b97 fix(repository_models_pre_oci): fixed how we called a field 
Issue: NA

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-28 14:14:20 -04:00
Charlton Austin
78f77017e8 Merge pull request #2829 from charltonaustin/fix_bug_with_v2_2 
fix(error with repository): removed a field that is not being used
 2017-07-27 10:40:43 -04:00
Charlton Austin
11b1dca994 fix(error with repository): removed a field that is not being used 
this causes an exception when getting releases

Issue: https://coreosdev.atlassian.net/browse/QUAY-753

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-27 10:20:55 -04:00
Jimmy Zelinskie
155cb65f7d endpoints.appr: move to new v22 format 2017-07-26 11:02:44 -07:00
Joseph Schorr
f0b932559d Reporting the expiration got lost in a rebase 
This ensure the tag expiration shows up in the UI
 2017-07-26 11:29:21 -04:00
Charlton Austin
7d5e4dd6d3 refactor(endpoints/api/robot*): adding in database interface 
this creates a layer of abstraction so we can move to v2-2 easier

Issue: https://coreosdev.atlassian.net/browse/QUAY-630

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-26 10:21:09 -04:00
Joseph Schorr
48c79003c6 yap 2017-07-25 17:18:06 -04:00
Joseph Schorr
e7d6e60d97 Update for merge and make additional interface improvements 2017-07-25 17:00:08 -04:00
Joseph Schorr
e7fec9dd20 Change get_sample_data API to not require the custom notification tuple 2017-07-25 17:00:07 -04:00
Joseph Schorr
e7dbc4ee91 Move notification helper code into the root module 2017-07-25 17:00:07 -04:00
Joseph Schorr
ce56031846 Move notifications into its own package 2017-07-25 17:00:06 -04:00
Charlton Austin
be206a8b88 Merge pull request #2814 from charltonaustin/create_data_interface_for_subsystem_api/repository_633 
refactor(endpoints/api/repository*): added in pre_oci_model abstraction
 2017-07-25 13:59:52 -04:00
Evan Cordell
ac4ab92f03 Merge pull request #2802 from ecordell/QUAY-644/endpoints-api-init-v22 
add pre-oci models for endpoints/api/__init__.py
 2017-07-25 13:57:21 -04:00
Joseph Schorr
72a9652d0f Change suconfig to use a data model interface 2017-07-24 16:30:44 -04:00
josephschorr
074b4e4981 Merge pull request #2810 from coreos-inc/joseph.schorr/QUAY-747/common-data-interface 
Convert endpoints/common into using a data interface
 2017-07-24 15:59:13 -04:00
Charlton Austin
8f1200b00d style(data, endpoints, test): ran yapf against changed files 
### Description of Changes

Issue: https://coreosdev.atlassian.net/browse/QUAY-633

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-24 11:05:15 -04:00
Charlton Austin
9e1106f164 refactor(endpoints/api/repository*): added in pre_oci_model abstraction 
this is a part of getting ready for oci stuff

[TESTING->using new PR stack]

Issue: https://coreosdev.atlassian.net/browse/QUAY-633

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-24 11:03:03 -04:00
Joseph Schorr
95850b6148 Switch image API to use a data interface 2017-07-21 14:38:31 -04:00
Joseph Schorr
9b22afd8fd wip 2017-07-21 13:09:21 -04:00
josephschorr
94d516a2c8 Merge pull request #2813 from coreos-inc/joseph.schorr/QUAY-701/team-sync-nonsuperuser 
Add option for self-service team synchronization
 2017-07-21 12:58:29 -04:00
josephschorr
009ca829e8 Merge pull request #2803 from coreos-inc/joseph.schorr/QUAY-627/signing-data-interface 
Change signing API to use a data model interface
 2017-07-21 12:58:11 -04:00
Joseph Schorr
8a96647d6e Add feature flag to enable team syncing setup when not a superuser 2017-07-21 11:06:21 -04:00
Joseph Schorr
f976ffbdc7 Change endpoints/common to use a data interface 2017-07-20 16:01:39 -04:00
Joseph Schorr
aecec02b6c Change common_login to take in a user uuid, instead of a user DB object 2017-07-20 16:01:39 -04:00
Joseph Schorr
7736de24fe Add common_login test 2017-07-20 16:01:39 -04:00
Joseph Schorr
41ac9019c6 Small formatting improvements to common 2017-07-20 16:01:38 -04:00
Joseph Schorr
5d69fc2aa3 Move param_required into the decorators module 2017-07-20 16:01:38 -04:00
Joseph Schorr
98e2ccf74d Move parse_repository_name into decorators 2017-07-20 16:01:38 -04:00
Joseph Schorr
a64f268344 Remove unused random_string method 2017-07-20 16:01:38 -04:00
Joseph Schorr
0531f6c749 Small cleanups to the decorators file 2017-07-20 16:01:38 -04:00
Jimmy Zelinskie
d7b094f65c Merge pull request #2801 from jzelinskie/keyserver-update 
endpoints.keyserver: new fs org for data interface
 2017-07-20 14:48:57 -04:00
Joseph Schorr
17f3de811e Move route_show_if into decorators 
Also removes unused route_hide_if
 2017-07-20 11:07:31 -04:00
josephschorr
a6db05e8b5 Merge pull request #2718 from coreos-inc/tag-expiration 
Formal tag expiration support
 2017-07-19 17:48:11 -04:00
josephschorr
b8e5a21736 Merge pull request #2663 from coreos-inc/multi-instance-su-panel 
Disable debug logs in superuser panel when under multiple instances
 2017-07-19 17:28:05 -04:00
Joseph Schorr
9679ec91ec Fix for hard merge 2017-07-19 17:13:49 -04:00
Joseph Schorr
7d4fed6892 Change error message when trying to pull a deleted or expired tag 
Will let the users know they can recover the tag via time machine

Note: This was tested with the Docker protocol, but the new error code is *technically* out of spec; we should make sure its okay.
 2017-07-19 17:13:48 -04:00
Joseph Schorr
99d7fde8ee Add UI for viewing and changing the expiration of tags 2017-07-19 17:13:48 -04:00
Joseph Schorr
c5d8b5f86b Add support for tag expiration based on a quay.expires-after label 2017-07-19 17:13:06 -04:00
Joseph Schorr
7b8ce1df4c Change signing API to use a data model interface 2017-07-19 16:29:58 -04:00
Charlton Austin
ae30a40921 Merge pull request #2800 from charltonaustin/create_data_interface_for_subsystem_api/logs_628 
refactor(endpoints/api/logs*): Refactor to new data model
 2017-07-19 15:51:57 -04:00
Charlton Austin
a7c818543d refactor(endpoints/api/logs*): Refactor to new data model 
moving things away from peewee data model to data model interface

[TESTING->locally with docker compose]

Issue: https://coreosdev.atlassian.net/browse/QUAY-628

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-19 13:43:27 -04:00
josephschorr
38d3417ca7 Merge pull request #2636 from coreos-inc/auth-health-check 
Add support to health checks for auth and make health checks more descriptive
 2017-07-19 12:55:37 -04:00
Alec Merdler
a1ed482200 Merge pull request #2737 from alecmerdler/data-interface-refactor-api/subscribe 
refactor(/endpoints/api/subscribe.py): data interfaces
 2017-07-19 10:06:59 -04:00
alecmerdler
791bd5aefc refactored endpoints.api.subscribe to use abstracted data interface 2017-07-19 09:47:13 -04:00
Joseph Schorr
b7d6bb12fa Hide extended health check information behind superuser permission or a session property 
Also adds an endpoint that (when specified with the proper secret), sets the session property
 2017-07-19 16:17:02 +03:00
Evan Cordell
cb02610bfb fix bad merge 2017-07-18 15:52:06 -04:00
Evan Cordell
b8fc20c191 add pre-oci models for endpoints/api/__init__.py 2017-07-18 15:37:44 -04:00
Evan Cordell
dd58008470 Add docs to data interface for repo notifications 2017-07-18 14:21:22 -04:00
Evan Cordell
3db8d54a31 delete weird incomplete refactor 2017-07-18 11:20:58 -04:00
Evan Cordell
94c28b624e fix tests after rebase, use _get_namespace_name_from 2017-07-18 11:07:55 -04:00
Evan Cordell
57517adef3 Add tests for repository notification api 2017-07-17 17:56:32 -04:00
Evan Cordell
9dad44e93d Don't use repository object anywhere in endpoints/api/repositorynotification 
Also adds support for audit logging with repo name only
 2017-07-17 17:55:00 -04:00
Evan Cordell
047722b295 add data interface and pre oci impelementation for repo notifications 2017-07-17 17:53:08 -04:00
Jimmy Zelinskie
42869cb00a endpoints.keyserver: new fs org for data interface 2017-07-17 14:25:18 -04:00
Charlton Austin
69a0a10ab4 fix(endpoints/notificationmethod.py): deals with pre oci and the previous data model 
Issue: NA

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-14 10:32:38 -04:00
josephschorr
2f750bfc87 Merge pull request #2788 from coreos-inc/fix-notifications 
Fix notification system to use the new tuple correctly
 2017-07-14 00:26:16 +03:00
Joseph Schorr
63a97b6d2f Add a TODO 2017-07-14 00:21:55 +03:00
Charlton Austin
48ed4f2875 Merge pull request #2787 from charltonaustin/create_data_interface_for_subsystem_api/repoemail_626 
refactor(endpoints/api/repoemail): added in pre_oci model
 2017-07-13 16:54:09 -04:00
Joseph Schorr
bf3e941d7f Fix notification system to use the new tuple correctly 2017-07-13 22:43:26 +03:00
Charlton Austin
bbe9b033d0 style(endpoints/api/repoemail): ran yapf 
### Description of Changes

Issue: https://coreosdev.atlassian.net/browse/QUAY-626

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-13 15:34:48 -04:00
Charlton Austin
d01b55f27d refactor(endpoints/api/repoemail): added in pre_oci model 
### Description of Changes

this is so we can abstract away the data interface

[TESTING->locally with docker compose]

Issue: https://coreosdev.atlassian.net/browse/QUAY-626

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-13 15:30:07 -04:00
Jimmy Zelinskie
9f4ffca736 Merge pull request #2751 from jzelinskie/registry-tests 
test: convert registry auth test to pytest
 2017-07-13 15:09:57 -04:00
josephschorr
fdb21aa5dc Merge pull request #2777 from coreos-inc/joseph.schorr/QUAY-618/notificationworker-data-interface 
Change notificationworker to use data interface
 2017-07-13 00:23:15 +03:00
Charlton Austin
82488c9102 Merge pull request #2753 from charltonaustin/api_tag_v22 
refactor(endpoints/api/tag): refactor code for v22
 2017-07-12 15:51:48 -04:00
Jimmy Zelinskie
7d1bbbfe19 test: convert registry auth test to pytest 
This also moves them into the auth package.
 2017-07-12 15:14:12 -04:00
Charlton Austin
131acde317 refactor(data+endpoints): code review changes 
this puts the view logic on the object and adds a parameter for logging

[TESTING->locally with docker compose]

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-12 14:10:21 -04:00
Joseph Schorr
b6f1782642 Change notificationworker to use a data interface 2017-07-12 17:40:45 +03:00
Evan Cordell
939ddfd1d7 Merge v2.4.0-release into cherrypick-2.4.0 2017-07-10 10:25:18 -04:00
Charlton Austin
897a091692 style(data+endpoints): ran yapf 
### Description of Changes

ran yapf for the branch

[TESTING->locally using docker compose]

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-10 09:46:02 -04:00
Charlton Austin
fc4b3642d3 refactor(endpoints/api/tag): refactor code for v22 
this decouples the database models from the api

[TESTING->locally with docker compose]

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-07-10 09:40:33 -04:00
Evan Cordell
d4ef594c13 Mark fields as required on globalmessages API so that they are 
properly checked when the request comes in
 2017-07-05 18:16:55 -04:00
Antoine Legrand
cdb3722c17 Use $QUAYPATH and $QUAYDIR in conf and init files 2017-07-05 16:23:54 +02:00
josephschorr
89ab94ffbb Merge pull request #2720 from coreos-inc/gc-opt 
GC optimizations
 2017-06-29 20:55:14 +03:00
Jimmy Zelinskie
92e978fa0f endpoints.v2: yapf format 2017-06-29 13:24:00 -04:00
Jimmy Zelinskie
ecd5996386 endpoints.v2: new fs layout for data interface 
Fixes QUAY-656
 2017-06-29 13:19:53 -04:00
Charlton Austin
fdb63632b0 Merge branch 'master' into create_data_interface_for_subsystem_api/tag_632 2017-06-29 10:33:15 -04:00
josephschorr
0e702c72f2 Merge pull request #2739 from coreos-inc/joseph.schorr/QUAY-664/verbs-interface-refactor 
Refactor Verbs model definitions to match new style
 2017-06-29 10:07:36 +03:00
Joseph Schorr
d07cc91dc6 yapf 2017-06-29 09:57:39 +03:00
Charlton Austin
400b346953 test(endpoints/api): add in test for tag 
this adds tests for the pro oci model

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-06-28 15:14:03 -04:00
Jimmy Zelinskie
80c9b611a4 Merge pull request #2730 from jzelinskie/v2-interface 
endpoints.v2: new fs layout for data interface
 2017-06-28 13:51:43 -04:00
Joseph Schorr
8b4958dbcc Move verbs model into new file structure 2017-06-28 13:05:02 +03:00
Joseph Schorr
8ac20edfb2 Move verbs security tests into pytest style 2017-06-28 12:48:02 +03:00
Joseph Schorr
2f018046ec Move conduct_call into a common test lib for all endpoints 2017-06-28 11:38:36 +03:00
Charlton Austin
337b68abdc style(endpoints/api/tag*): ran yapf 
### Description of Changes

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

## Reviewer Checklist

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-06-27 14:24:23 -04:00
Charlton Austin
941cb4b4ee refactor(endpoints/api/tag*): adding in new support for tags api 
this creates an interface for hidding details of the data model for pre oci and post oci code

Issue: https://coreosdev.atlassian.net/browse/QUAY-632

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-06-27 13:53:11 -04:00
Joseph Schorr
8dcea30d58 Fix build by pre-calling the caches 
They were being called in a test-dependent order, which caused any tests which relied on query count to fail
 2017-06-27 18:11:46 +03:00
Joseph Schorr
11659f73bf Fix log for reenabling a notification 
We forgot to log the event and method names
 2017-06-27 15:26:40 +03:00
Jimmy Zelinskie
b1434b0380 endpoints.v2: yapf format 2017-06-26 18:22:17 -04:00
Jimmy Zelinskie
0e26a03f7e endpoints.v2: new fs layout for data interface 
Fixes QUAY-658
 2017-06-26 18:21:35 -04:00
Charlton Austin
0841d2bfb9 Merge pull request #2715 from charltonaustin/fix_endpoint_error 
fix(endpoints): added in proper error handling
 2017-06-21 17:00:38 -04:00
Charlton Austin
5e6aa6648b fix(endpoints): added in proper error handling 
before we would return a 400 without a message because the errors were not being caught

Issue: https://www.pivotaltracker.com/story/show/145459707

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-06-21 16:59:48 -04:00
Joseph Schorr
159badf7ed Only send internal cancelation emails if the user canceled themselves 
In the other case (where payment failed), we already auto-email the customer
 2017-06-16 14:27:55 -04:00
Evan Cordell
b6d423a50d Merge pull request #2687 from ecordell/enable-builds-trust 
Re-enable builds and tag modification when signing is enabled
 2017-06-13 11:20:04 -04:00
Antoine Legrand
817d75d6dc Merge pull request #2697 from coreos-inc/appr_blob_pull 
Appr: fix pull blob (missing param)
 2017-06-13 16:28:00 +02:00
josephschorr
b269cb84a3 Merge pull request #2688 from coreos-inc/build-badge-query 
Remove expensive call in build badge
 2017-06-12 15:06:13 -04:00
Joseph Schorr
a949a44cb2 Remove expensive call in build badge 
We don't need to list all the tags to determine if any exist, and showing the repo is ready when it is empty is probably correct behavior anyway
 2017-06-12 14:53:54 -04:00
josephschorr
51a952d50c Merge pull request #2680 from coreos-inc/catalog-fixes 
Various small catalog fixes
 2017-06-09 13:43:11 -04:00
alecmerdler
9db3600463 append file hash to frontend Webpack bundle for cachebusting instead of random string 2017-06-08 13:08:38 -07:00
Antoine Legrand
f0dd2e348b Merge pull request #2551 from coreos-inc/structured-logs 
Add log formatter class
 2017-06-07 08:22:18 -07:00
Evan Cordell
2e30c47045 Re-enable builds and tag modification when signing is enabled 2017-06-07 10:01:37 -04:00
Antoine Legrand
3c99928a27 Add log JSON formatter 2017-06-07 00:02:52 +02:00
Antoine Legrand
9c68cbd6e8 Fix no search result for apps 2017-06-05 23:03:47 +02:00
Joseph Schorr
555041876d Make public catalog only enabled via a feature flag 2017-06-02 15:30:51 -07:00
Joseph Schorr
f44df49236 Add support for last param in pagination to match catalog spec 2017-06-02 12:03:50 -07:00
Joseph Schorr
9518f1d045 Disable debug logs in superuser panel when under multiple instances 
They don't work anyway (since logs will be loaded from random instances), so we just disable them
 2017-05-24 14:34:29 -04:00
Evan Cordell
c55c233f1f Merge pull request #2646 from ecordell/kubernetes-ca-fix 
ConfigProviders abstract over path construction
 2017-05-24 11:37:17 -04:00
josephschorr
8e8470890a Merge pull request #2653 from coreos-inc/new-signing-ui 
Implement updated UI for displaying the signing status of a tag, now …
 2017-05-24 11:31:52 -04:00
Evan Cordell
897da1df67 Fix tuf api calls 2017-05-23 12:36:49 -04:00
Alec Merdler
bfe4a050c4 Merge pull request #2658 from alecmerdler/webpack-overhaul 
Replace Grunt with Webpack as Front-End Build Tool
 2017-05-22 14:31:37 -07:00
Alec Merdler
97256841bd Refactor Manage Trigger to Single Workflow (#2577) 
* Refactor Manage Trigger to Single Workflow
 2017-05-22 13:59:12 -07:00
alecmerdler
2e133d2b9c replaced Grunt with Webpack as front-end build tool 2017-05-22 12:00:51 -07:00
Charlton Austin
a71f60a9c1 Merge pull request #2652 from charltonaustin/failing_repository_notifications_to_be_disabled_after_n_failures_in_a_row_144646649 
Failing repository notifications to be disabled after n failures in a row 144646649
 2017-05-22 09:30:53 -04:00
Charlton Austin
993f2a174c feat(full-stack): disable notifications after 3 failures 
This stops notifications from firing over and over again if they are repeatedly failing.

[TESTING -> locally with docker compose, DATABASE MIGRATION -> there is a single migration]

Issue: https://www.pivotaltracker.com/story/show/b144646649n

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-05-19 16:58:46 -04:00
Charlton Austin
2282af2619 style(workers/notificationworker.py): formatted file 
[TESTING -> locally]

Issue: https://www.pivotaltracker.com/story/show/b144646649n

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-05-19 16:58:22 -04:00
Joseph Schorr
065e327190 Make sure catalog always returns public repositories 2017-05-19 16:24:08 -04:00
Joseph Schorr
b7f88d2df2 Implement updated UI for displaying the signing status of a tag, now that we support multiple delegations 
The icon now represents the status of the multiple delegations, and we show each delegation in the "Expanded" view.
 2017-05-19 15:50:51 -04:00
Antoine Legrand
f558b1728d App: allow blob pull 2017-05-19 12:48:02 +02:00
Jimmy Zelinskie
ad18e01bef Merge pull request #2648 from jzelinskie/fix-appr-tests 
endpoints: s/releasse/release/g
 2017-05-17 21:03:00 -04:00
Jimmy Zelinskie
2c874df5ce endpoints: s/releasse/release/g 2017-05-17 12:07:07 -04:00
Evan Cordell
01b59e8d66 ConfigProviders abstract over path construction 
Fixes issue where certs can't be uploaded in UI in k8s
 2017-05-17 08:12:09 -04:00
Jimmy Zelinskie
702cdf59ff Merge pull request #2637 from jzelinskie/audit-apps 
Audit Logs for Apps
 2017-05-16 17:06:25 -04:00
Jimmy Zelinskie
4db789b656 add audit logging to app registry endpoints 2017-05-16 15:54:02 -04:00
Charlton Austin
6023e15274 Merge pull request #2638 from charltonaustin/fix_build 
fix(endpoints): fix build
 2017-05-12 15:32:19 -05:00
Charlton Austin
e8c4cc49bd fix(endpoints): fix build 
forgot to add this

Issue: https://www.pivotaltracker.com/story/show/144661631

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-05-12 15:27:56 -05:00
Charlton Austin
18e01369d4 Merge pull request #2632 from charltonaustin/quay_cant_find_a_dockerfile_in_a_branch_of_a_github_repo_144661631 
fix(trigger.py): fixed robot view no dockerfile
 2017-05-12 15:21:41 -05:00
Charlton Austin
4ec55665de fix(endpoints): add tests 
this adds tests to the analyze trigger api

[testing -> locally using pytest]

Issue: https://www.pivotaltracker.com/story/show/144661631

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-05-12 13:58:05 -05:00
Jake Moshenko
4189422340 Use MAIL_DEFAULT_SENDER as the sender in email notifications 2017-05-10 14:24:27 -04:00
Charlton Austin
3b728014ac fix(trigger.py): fixed robot view no dockerfile 
fixed how we create views where there is no dockerfile available

[TESTING -> local with dockerfile build]

Issue: https://www.pivotaltracker.com/story/show/144661631

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
 2017-05-08 17:18:03 -04:00
Joseph Schorr
db767b3610 Optimize lookup of org membership on prototype and perms APIs 
Fixes a major slowdown when working with permissions under organizations with a lot of members

Fixes https://www.pivotaltracker.com/story/show/144076113
 2017-05-08 14:03:59 -04:00
josephschorr
5d88bccef7 Merge pull request #2617 from coreos-inc/search-ordering 
Search ordering and performance fixes
 2017-05-04 13:16:30 -04:00
Joseph Schorr
227aa8ab8c Ensure that search doesn't make extra SQL lookups 
Before this change, we were  accessing the `.kind` on the repository object, which caused peewee to make an extra lookup for each result
 2017-05-04 13:08:09 -04:00
EvB
467c72a9ac code-stye Yapf: 2 files updated 2017-05-04 11:33:36 -04:00
EvB
25b9d044de test(api/tag): test restore_tag 2017-05-04 11:19:25 -04:00
EvB
6e894d5f24 refactor(api/tag): remove try/catch 2017-05-04 11:19:25 -04:00
EvB
eb9db0c53b test(api/tag): unit test movetag 2017-05-04 11:19:25 -04:00
EvB
70508e3692 feat(api/tag): generate manifest on revert_tag action 2017-05-04 11:19:25 -04:00
EvB
f7bf6a223c feat(api/tag): generate manifest on tag 2017-05-04 11:19:25 -04:00
Evan Cordell
2495091a53 Merge pull request #2602 from ecordell/sni 
Add test for SNI support
 2017-05-02 15:57:44 -04:00
josephschorr
5a9a231754 Merge pull request #2529 from coreos-inc/search-ui 
Implement new search UI
 2017-05-02 15:56:59 -04:00
Evan Cordell
7a96db0945 Add test for SNI support 2017-05-02 13:14:30 -04:00
Evan Cordell
738f53f61a Merge pull request #2597 from ecordell/sni 
TUF metadata api SNI support
 2017-05-02 13:01:16 -04:00
Evan Cordell
b2569ffbb2 Support SNI in python requests, and only delete tuf metadata if it 
exists
 2017-05-02 09:32:12 -04:00
Joseph Schorr
ae0d1e831b Add prometheus metric for queued builds 2017-05-01 15:16:55 -04:00
Joseph Schorr
3e8bc07b6c Fix show_if ordering and add a check that fails if misordered 
Before this change, these endpoints still existed even if the flag was off
 2017-05-01 13:14:20 -04:00
Joseph Schorr
e9ffe0e27b Implement new search UI 
We now have both autocomplete-based searching for quick results, as well as a full search page for a full listing of results
 2017-04-28 13:57:28 -04:00
josephschorr
8b148bf1d4 Merge pull request #2576 from coreos-inc/full-db-tests-tox 
Reenable full database testing locally and in concourse
 2017-04-27 18:09:15 -04:00
EvB
5e995fae20 refactor(archivedlogs): move archivelog handler to endpoints 2017-04-26 11:41:55 -04:00
Joseph Schorr
d895b4d5ff Fix appr tests to use the shared test fixtures 2017-04-24 23:08:28 -04:00
Joseph Schorr
7debd44b54 Switch fixture imports to wildcard in prep for full db test fixes 2017-04-24 16:45:14 -04:00
Antoine Legrand
8499612c4c Merge pull request #2538 from coreos-inc/enable-robot-cnr 
Enable robot cnr
 2017-04-24 17:32:46 +02:00
Joseph Schorr
3dcbe3c631 If enabled, allow users and orgs to set their time machine expiration 
Fixes https://www.pivotaltracker.com/story/show/142881203
 2017-04-21 11:32:45 -04:00
Joseph Schorr
eb5cebbcdf Have tag operations dialog reflect time machine configuration 
If a tag deletion is going to remove images, but those images are not going to be removed immediately, we need to message that

Fixes https://www.pivotaltracker.com/story/show/143063199
 2017-04-21 11:32:25 -04:00
Joseph Schorr
8981fcab78 Make sure we don't internal error when signing is disabled 2017-04-19 12:27:01 -04:00
Antoine Legrand
599ce0de54 code-stye Yapf: 5 files updated 
data/interfaces/appr.py endpoints/appr/cnr_backend.py endpoints/appr/registry.py endpoints/appr/test/test_api.py endpoints/appr/test/test_registry.py
 2017-04-18 14:02:48 +02:00
Antoine Legrand
578f87f94c Fix login with robot to quay-appr 2017-04-18 13:59:21 +02:00
Joseph Schorr
9601fd44f6 Small fixes to signing related APIs 2017-04-17 18:04:06 -04:00