vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
9215 commits 2 branches 62 tags 205 MiB
Commit graph

2450 commits

Author SHA1 Message Date
Joseph Schorr
93d79e777e Automatically disable build triggers with successive failures or internal errors 
We allow users to reenable them manually once disabled
 2018-03-01 16:49:51 -05:00
Joseph Schorr
c35eec0615 Add ability for triggers to be disabled 
Will be used in the followup commit to automatically disable broken triggers
 2018-03-01 16:49:28 -05:00
Joseph Schorr
8bc55a5676 Make namespace deletion asynchronous 
Instead of deleting a namespace synchronously as before, we now mark the namespace for deletion, disable it, and rename it. A worker then comes along and deletes the namespace in the background. This results in a *significantly* better user experience, as the namespace deletion operation now "completes" in under a second, where before it could take 10s of minutes at the worse.

Fixes https://jira.coreos.com/browse/QUAY-838
 2018-02-27 13:12:51 -05:00
Joseph Schorr
e857c676db Have cor-checkable-menus reflect the filtered set of items 
Fixes https://jira.coreos.com/browse/QUAY-837
 2018-02-21 16:38:21 -05:00
Brad Ison
62971b7f20
Merge pull request #2999 from bison/user-location 
Add user location metadata filed
 2018-02-20 16:48:37 -05:00
Joseph Schorr
188ea98441 Add new decorator to prevent reflected text attacks 
Instead of disabling repo names with periods in them, we simply disallow calls to the API when they are GET requests, whose path ends in a dot, and that do not have a referrer from the frontend.
 2018-02-20 11:33:45 -05:00
Joseph Schorr
72ca758c88 Add messaging when trying to create a team that already exists 
Fixes https://jira.coreos.com/browse/QUAY-827
 2018-02-15 16:03:09 -05:00
Joseph Schorr
8c14a8fdf2 Fix language for expiring app tokens notification 2018-02-12 16:56:06 -05:00
Brad Ison
3de6b4a646 Add location metadata field for users 2018-02-06 16:06:17 -05:00
Joseph Schorr
de47b13c24 Add superuser config for Azure blob storage 2018-02-06 13:48:40 -05:00
josephschorr
944e9e9f1f
Merge pull request #2983 from coreos-inc/joseph.schorr/QUAY-781/login-binding 
Enable setting the login binding field for Github and Google login
 2018-02-02 15:34:53 -05:00
josephschorr
6514bf229f
Merge pull request #2973 from coreos-inc/joseph.schorr/QS-116/cloudfront-storage 
Add support for configuring cloudfront storage
 2018-02-02 10:14:28 -05:00
Joseph Schorr
1b707660de Hide build-related UI elements when builds are disabled 
Fixes https://jira.coreos.com/browse/QUAY-807
 2018-01-31 18:09:38 -05:00
Joseph Schorr
b0f656731c Add support for configuring CloudFront storage engine 
Fixes https://jira.coreos.com/browse/QS-116
 2018-01-31 11:22:14 -05:00
Joseph Schorr
868a3df2d8 Change positioning and sizing of external login buttons to be nicer looking, using flex box 
Fixes https://jira.coreos.com/browse/QUAY-806
 2018-01-31 11:05:42 -05:00
Joseph Schorr
8714ad6fe3 Fix NPE when app specific tokens are not enabled 2018-01-26 13:18:32 -05:00
Joseph Schorr
498c29ca89 Enable setting the login binding field for Github and Google login 
Right now, this is mostly a cut and paste job, which is a bit ugly, but works. Longer term, I've filed https://jira.coreos.com/browse/QUAY-801 to remove the custom code for Github and Google and, instead, support them generically as part of our OIDC provider setup

Fixes https://jira.coreos.com/browse/QUAY-781
 2018-01-25 15:21:37 -05:00
Joseph Schorr
f726e8c972 Fix typo in expiration status view 
Fixes https://jira.coreos.com/browse/QS-119
 2018-01-11 17:29:48 -05:00
Joseph Schorr
20b9a40585 Hide trigger information that isn't present 
Fixes https://jira.coreos.com/browse/QS-115
 2018-01-10 11:20:35 -05:00
Joseph Schorr
dfb436a3ce Change LDAP password field to be a password field 
Fixes https://jira.coreos.com/browse/QS-114
 2018-01-09 16:31:52 -05:00
Joseph Schorr
16c16371f4 Have the credentials dialog use the title, if one is specified 2018-01-05 14:10:54 -05:00
Joseph Schorr
ace6a35707 Add the image ID to the expanded state in the tags view 2018-01-05 14:03:40 -05:00
IvanCherepov
fd5e2f3cdf
change href link with a wrong email to just sales email address (#2960) 2018-01-05 12:50:26 -05:00
Joseph Schorr
888b564a9b Add a banner to the Quay UI when an app specific token is about to expire 2018-01-04 15:27:42 -05:00
Joseph Schorr
524d77f527 Add an AppSpecificAuthToken data model for app-specific auth tokens. These will be used for the Docker CLI in place of username+password 2018-01-04 15:27:41 -05:00
Joseph Schorr
d97e04d23f Add data transfer limits FAQ 2018-01-04 13:50:45 -05:00
josephschorr
db0b28eadb
Merge pull request #2957 from coreos-inc/joseph.schorr/QS-104/time-display-bug 
Remove single bind on time-ago component
 2018-01-04 11:20:38 -05:00
Joseph Schorr
c9fd579b06 Remove single bind on time-ago component 
The component is occasionally used for date times that change, so we cannot single bind

Fixes https://jira.coreos.com/browse/QS-104
 2018-01-04 11:17:44 -05:00
IvanCherepov
6abfa24ad4
Replaced account.tectonic.com with account.coreos.com (#2956) 
Fixed an outdated message on how to get Raw Quay Enteprise license during the setup
 2018-01-03 09:32:01 -05:00
Joseph Schorr
d95a9e3c59 Change tag history revert operation to apply to the *current* entry, rather than the "next" 
Before this change, the restore operation next to a history entry would bring the tag back to the state *at that entry*, rather than *before that entry*, which is neither the expected behavior, nor allowed for an immediate restore when moving a tag. This fixes the problem.

Fixes https://jira.coreos.com/browse/QS-100
 2017-12-20 16:23:17 -05:00
Joseph Schorr
72bfebdb60 Add license validation to the config validation check 
Should prevent a customer from accidentally saving a config that violates their license

Fixes https://jira.coreos.com/browse/QS-97
 2017-12-19 13:44:08 -05:00
Joseph Schorr
0a176d0abe Fix plans manager display to be less confusing when we show deprecated plans 2017-12-18 11:45:15 -05:00
josephschorr
44c77b4cbb
Merge pull request #2931 from coreos-inc/joseph.schorr/QS-76/oidc-scopes 
Allow admins to configure the login scopes for OIDC login
 2017-12-08 13:33:06 -05:00
Joseph Schorr
1d1c6f0606 Invalidate all session tokens when a user signs out 
Fixes https://jira.coreos.com/browse/QS-85
 2017-12-07 13:03:11 -05:00
Joseph Schorr
c55ad59f1f Allow admins to configure the login scopes for OIDC login 
Some OIDC implementations return a larger set of scopes than is necessary, so we allow admins to override.
 2017-12-06 15:54:26 -05:00
josephschorr
b9ad8bbb5d
Merge pull request #2934 from coreos-inc/joseph.schorr/QS-78/email-recovery 
Security fixes for password recovery
 2017-12-06 14:53:02 -05:00
Joseph Schorr
a204dc20fb Require CAPTCHA for password recovery 
https://jira.coreos.com/browse/QS-79
 2017-12-06 14:25:34 -05:00
Joseph Schorr
927d469db0 In password recovery, don't reveal whether an e-mail address is valid (unless it is an org's e-mail address) 2017-12-06 14:07:38 -05:00
Joseph Schorr
a2caebbb62 Fix XSS in usage log viewer 
Fixes https://jira.coreos.com/browse/QS-82
 2017-12-06 13:49:02 -05:00
Joseph Schorr
4db1615d94 Fix bugs in updateuser 
1) Also check for matching organization names
2) Ensure that errors don't leave the throbber
 2017-12-01 14:58:29 -05:00
Joseph Schorr
2ced523313 Add Explore tab and query-less searching 
Allows for exploration of all visible repositories, in paginated form.

This change also fixes the layout of the header on different viewport sizes to be consistently a single line in height.

Fixes https://jira.coreos.com/browse/QS-63
 2017-11-28 16:50:23 +02:00
Joseph Schorr
c7e439f593 Set a default error message for resource views 
Ensures that we don't display an empty error box
 2017-11-28 15:38:48 +02:00
josephschorr
78d0a7ae79
Merge pull request #2916 from coreos-inc/joseph.schorr/QS-67/start-build-bug 
Hide "Start Build" button in builds tab if not accessible
 2017-11-27 17:01:00 +02:00
Joseph Schorr
49dff5729c Switch time display components to use locale-aware format strings 2017-11-27 16:03:54 +02:00
Joseph Schorr
db53f82a34 Shorten the default date/times shown 2017-11-27 13:19:26 +02:00
Joseph Schorr
110fac1902 Switch logs view to use <time-display> component 2017-11-27 13:19:18 +02:00
Joseph Schorr
b5b4aa154c Add support for date-only to the time-display component 2017-11-27 13:08:38 +02:00
Joseph Schorr
89d635f6cf Change to use the <time-display> component 2017-11-27 12:56:26 +02:00
Joseph Schorr
7d55ff9c67 Add a <time-display> component for better display of time 2017-11-27 12:56:06 +02:00
Joseph Schorr
2ea06d3df8 Change all uses of am-time-ago to the <time-ago> component 2017-11-27 12:41:19 +02:00
Joseph Schorr
33af54d355 Add a <time-ago> component to abstract out common handling of showing how long ago an event occurred 2017-11-27 12:40:58 +02:00
Joseph Schorr
b9768ef6cf Remove unused component 2017-11-27 12:40:08 +02:00
Joseph Schorr
7a8850289e Hide "Start Build" button in builds tab if not accessible 
While the build cannot be started, and, in fact, the only way to see the button is to *manually* set the `tab=` query param, better to hide it

Fixes https://jira.coreos.com/browse/QS-67
 2017-11-27 12:02:07 +02:00
Joseph Schorr
17a0bc0fab Fix CSS formatting of tag history display to not overflow 
Fixes https://jira.prod.coreos.systems/browse/QS-59
 2017-11-13 16:37:57 -05:00
Joseph Schorr
0217ef34ea Trim Dockerfile commands to fix UI 
Docker is (for some reason) adding an extra space, so trim the command before parsing

Fixes https://jira.prod.coreos.systems/browse/QS-57
 2017-11-10 13:29:55 -05:00
Joseph Schorr
091b937ee3 Fix handling of promises for title and description of pages in Quay 
We were not correctly waiting for the `scope` on page to be filled before trying to calculate the title, and the logic for description was broken as well.
 2017-11-08 16:14:14 -05:00
Joseph Schorr
5380238919 Fix tag column width on smaller displays 
We change how we selectively hide columns to give more room to the tag column
 2017-11-08 15:58:34 -05:00
Joseph Schorr
703a64cd6a Add pull by digest to the fetch tag dialog 2017-10-25 15:02:39 -04:00
Joseph Schorr
86e4539c04 Add ability to copy the full SHA256 or V1ID for an image 
Clicking the little (SHA256) or (V1ID) bubble next to the ID will now show a dialog with a copy box.
 2017-10-25 14:56:59 -04:00
Joseph Schorr
f4433920c1 Fix bug in reading the updated_tags on a notification 
It is no longer an Object, but an array
 2017-10-24 15:24:33 -04:00
Joseph Schorr
1d593274dc Fix build links in notifications 
Fixes https://jira.prod.coreos.systems/browse/QS-33
 2017-10-20 14:03:51 -04:00
Joseph Schorr
8081b8424f Further NPE fix in tag signing display 
Fixes https://jira.prod.coreos.systems/browse/QS-37
 2017-10-17 13:13:19 -04:00
Joseph Schorr
ff3dac613a Fix bug in entity search that caused all robots and teams to be non-lazy loaded 
Should help immensely with repository page load time

Fixes https://coreosdev.atlassian.net/browse/QS-30
 2017-10-09 15:44:46 -04:00
Joseph Schorr
a7f02c5451 Handle NPE in tag signing display 2017-10-09 14:07:16 -04:00
Joseph Schorr
563f6b5187 Make update user throbber show if user is not yet loaded 2017-10-09 14:03:11 -04:00
Joseph Schorr
38748576a1 Fix NPE in updateuser code 
Fixes https://sentry.io/coreos/frontend-production/issues/364782088/
 2017-10-09 14:02:36 -04:00
Joseph Schorr
3b4296f580 Add missing var 2017-10-06 14:36:02 -04:00
Joseph Schorr
9bbc73af1d Forgot to close tabs, which caused bizarre dialog behavior 2017-10-06 13:51:02 -04:00
josephschorr
3bef21253d Merge pull request #2695 from coreos-inc/oidc-internal-auth 
OIDC internal auth support
 2017-10-02 16:51:17 -04:00
Joseph Schorr
f8f0c3e6ae Add documentation in the QE setup tool to show OIDC callback URLs 2017-09-28 14:58:43 -04:00
Joseph Schorr
82ff85b125 Add ability for users to change their name and company information 2017-09-26 16:58:04 -04:00
Alec Merdler
ad61df66c5 Merge pull request #2846 from alecmerdler/QUAY-682 
Optimize Webpack JS Bundle Size
 2017-09-18 16:47:30 -04:00
josephschorr
fa954466f7 Merge pull request #2867 from coreos-inc/invite-only 
Add support for invite-only user creation
 2017-09-15 14:29:50 -04:00
Joseph Schorr
ff80dad5b8 Add invitation required messaging 2017-09-15 11:42:09 -04:00
Joseph Schorr
6a8e57a353 Add superuser config for the invite-only feature 2017-09-14 16:28:39 -04:00
Joseph Schorr
804d3c46c3 Add feature flag to allow users to be created only if invited to join a team 
Allows for open user creation, but only if extended an invitation by someone who already has access
 2017-09-14 16:28:39 -04:00
Joseph Schorr
9a4c87795f Fix contacts setup in superuser panel 
Adds a missing import
 2017-09-14 15:40:11 -04:00
Joseph Schorr
c105123ad4 Add superuser config for prefix autocomplete setting 2017-09-12 15:57:57 -04:00
Joseph Schorr
ed897c7cb0 Change OIDC engine to not be federated 
We don't need linking, just the ability to perform lookup
 2017-09-12 12:26:41 -04:00
Joseph Schorr
bc82edb2d1 Add ability to configure OIDC internal auth engine via superuser panel 2017-09-12 12:23:52 -04:00
Joseph Schorr
e724125459 Add support for using OIDC tokens via the Docker CLI 2017-09-12 12:23:22 -04:00
josephschorr
46e1bd9c75 Merge pull request #2850 from coreos-inc/jpmc-features 
Features for JPMC
 2017-08-16 14:29:00 -04:00
Joseph Schorr
c85942b15c quay-require and ng-class don't work well together 
Fixes captcha display
 2017-08-08 11:16:41 -04:00
Joseph Schorr
650dbe5f5b Add config to enable "public" namespaces 
These are namespaces that will be displayed in the repo list view, regardless of whether the user is a member.
 2017-08-07 15:59:06 -04:00
Joseph Schorr
dff4207a89 Add feature flag to enable viewing builds and build logs for public repos 2017-08-07 15:24:36 -04:00
Alec Merdler
6dae6c4f82 whitelisted moment.js locales to reduce bundle size 2017-08-02 15:46:14 -04:00
Alec Merdler
82a08a942e removed Rickshaw dependency used by dead code 2017-08-02 10:27:44 -04:00
Alec Merdler
41c12c853c use Webpack code-splitting to dynamically import Highlight.js languages as they are detected by Showdown Markdown extension 2017-08-01 15:36:54 -04:00
Alec Merdler
8dc2a99926 refactored Markdown components to reduce bundle size 2017-08-01 10:55:05 -04:00
Antoine Legrand
fc8ba8b84e test yarn e2e 2017-07-28 15:03:35 +02:00
Alec Merdler
25f514a03d fixed status bar not showing 2017-07-26 11:24:12 -04:00
Joseph Schorr
ec71d787af Add config option to enable self-service team syncing 2017-07-21 11:16:19 -04:00
Alec Merdler
b11a51b62e fixed overflowing release name in application view 2017-07-20 11:23:52 -04:00
josephschorr
a6db05e8b5 Merge pull request #2718 from coreos-inc/tag-expiration 
Formal tag expiration support
 2017-07-19 17:48:11 -04:00
josephschorr
b8e5a21736 Merge pull request #2663 from coreos-inc/multi-instance-su-panel 
Disable debug logs in superuser panel when under multiple instances
 2017-07-19 17:28:05 -04:00
Joseph Schorr
05194664a9 Better typing on expiration status view 2017-07-19 17:13:49 -04:00
Joseph Schorr
a8b340feb6 Have tag ops dialog set the expiration date to the current date for the tag, by default 2017-07-19 17:13:49 -04:00
Joseph Schorr
1d600abc5d Fix bug in date time picker that prevents subsequent selection 2017-07-19 17:13:49 -04:00
Joseph Schorr
7d4fed6892 Change error message when trying to pull a deleted or expired tag 
Will let the users know they can recover the tag via time machine

Note: This was tested with the Docker protocol, but the new error code is *technically* out of spec; we should make sure its okay.
 2017-07-19 17:13:48 -04:00
Joseph Schorr
99d7fde8ee Add UI for viewing and changing the expiration of tags 2017-07-19 17:13:48 -04:00
Joseph Schorr
977539bf08 Abstract out an expiration status view into its own component 2017-07-19 17:13:48 -04:00
josephschorr
3b73695c04 Merge pull request #2724 from coreos-inc/multistage-build-ui 
Add support for multistage Docker build in build UI
 2017-07-19 09:30:22 -04:00
Alec Merdler
0cbe3bdf73 Merge pull request #2785 from alecmerdler/QUAY-542 
Use Repository Description in Web Search Results for Quay.io
 2017-07-17 10:48:20 -04:00
Alec Merdler
a9c2ea608d update application and repository views to set <meta> description to improve search results 2017-07-14 14:03:49 -04:00
Alec Merdler
6f1e8ae9b2 Merge pull request #2781 from alecmerdler/QUAY-734 
Manual Build Trigger UI Fix
 2017-07-14 14:01:27 -04:00
Alec Merdler
2814df482b display branchtag regex when manually invoking build triggers to avoid confusion when multiple triggers 2017-07-14 13:30:02 -04:00
Evan Cordell
45bf7efc84 Merge branch 'master' into no-signing-whitelist 2017-07-12 15:50:32 -04:00
Evan Cordell
75c1533aec Revert "Only show signing UI when namespace is explicitly whitelisted" 
85d382cd84
 2017-07-12 15:48:35 -04:00
alecmerdler
5e41de5370 maintain fixed-width columns when filtering cor-table 2017-07-12 14:02:55 -04:00
josephschorr
96d1fd128d Merge pull request #2757 from coreos-inc/joseph.schorr/QUAY-606/logarchive-georep 
Add support for QE customers to enable log rotation
 2017-07-12 00:30:04 +03:00
Ben Spoon
aa5bf227b8 Change helm registry url to github from coreos.com 2017-07-11 09:53:58 -07:00
Joseph Schorr
a13235c032 Fix typo 2017-07-10 18:35:51 +03:00
Evan Cordell
939ddfd1d7 Merge v2.4.0-release into cherrypick-2.4.0 2017-07-10 10:25:18 -04:00
Joseph Schorr
661c0e6432 Add superuser configuration for action log rotation 2017-07-10 13:22:29 +03:00
Evan Cordell
3e3e25bb5a Switch to new markdown editor everywhere 2017-07-05 17:35:26 -04:00
alecmerdler
41e7e559a6 added TSLint for TypeScript code style checking, fixed associated errors 2017-06-27 11:37:13 -07:00
Alec Merdler
e45ffb39d1 Merge pull request #2726 from alecmerdler/fix-cor-tabs-back-button 
Fix UI Tabs To Play Nicely with Browser Back Button
 2017-06-26 16:55:14 -07:00
alecmerdler
f78e1fb679 added end-to-end tests for cor-tabs in image repo view 2017-06-26 16:53:42 -07:00
alecmerdler
8c03a6be31 cor-tab-panel emits first registered tab ID if active tab is undefined 
adding e2e tests for cor-tabs
 2017-06-26 16:53:12 -07:00
alecmerdler
74ebf2a94b prevent invalid entity create form submission using enter key 2017-06-23 15:12:52 -07:00
Joseph Schorr
e0a1e05c52 Fix Dockerfile command view for FROM with as clause 2017-06-23 16:04:05 -04:00
Joseph Schorr
09e9b5cb53 Add support for multi-step phase delimitation in build logs view 2017-06-23 16:00:22 -04:00
Joseph Schorr
1d60414a23 Cleanup display of image commands to be better shared 
Also moves the work into a TS component
 2017-06-23 14:53:02 -04:00
Joseph Schorr
7f436bb54a Remove unused image-info-sidebar directive 2017-06-23 14:38:26 -04:00
alecmerdler
f5c1ae0719 fixed AngularJS escaping '?' character in URL 2017-06-23 11:27:07 -07:00
Joseph Schorr
62d7cb234c Move DockerfileCommand component into TS 2017-06-23 14:22:28 -04:00
Joseph Schorr
255bebcc92 Remove unused Dockerfile view directive 2017-06-23 13:32:11 -04:00
Joseph Schorr
70f26754b8 Add missing Dockerfile command colors 2017-06-23 13:21:41 -04:00
alecmerdler
31d518f3e1 added Protractor for end-to-end testing 2017-06-22 22:16:05 -07:00
alecmerdler
675127e0da fixed background CSS in setup 2017-06-22 19:12:15 -07:00
Joseph Schorr
6ae81ae50b Fix URI lib import in setup tool 
Move to web pack broke this
 2017-06-22 16:14:11 -04:00
alecmerdler
a46083ad57 fixed footer service status alignment 2017-06-16 14:15:27 -07:00
Jimmy Zelinskie
e028e159c0 add app registry config to setup tool: default off 2017-06-16 15:44:00 -04:00
Alec Merdler
ed2e32fb39 Merge pull request #2702 from alecmerdler/fix-app-view-settings-layout 
Fix App Settings View Layout Styling
 2017-06-14 13:05:03 -07:00
alecmerdler
7cd1e5208a fix app settings view layout styling 2017-06-14 12:42:35 -07:00
alecmerdler
5aa18456b7 removed ngReact module dependency 2017-06-14 12:30:21 -07:00
Alec Merdler
9c49093d2a Merge pull request #2700 from alecmerdler/karma-headless-chrome 
Use Headless Chrome for Unit Tests
 2017-06-14 12:04:36 -07:00
alecmerdler
e1210cd6df removed PhantomJS in favor of ChromeHeadless and upgraded Karma, removed Karma tests from Dockerfile 2017-06-13 17:04:07 -07:00
Evan Cordell
b6d423a50d Merge pull request #2687 from ecordell/enable-builds-trust 
Re-enable builds and tag modification when signing is enabled
 2017-06-13 11:20:04 -04:00
Evan Cordell
7b3cb9c8b7 Re-enable builds and tag operations in the UI 2017-06-13 09:56:47 -04:00
alecmerdler
9dfab42c0a remove React code, node-sass, and sass-loader dependencies 2017-06-08 11:19:25 -07:00
alecmerdler
1f9c3b142d fixed infinite cycle by removing getPattern function in favor of field.regex 2017-06-05 14:16:00 -07:00
Alec Merdler
c9cc2d9fdd Merge pull request #2681 from alecmerdler/fix-cor-cookie-tabs 
Fix CorCookieTabs Panel Undefined
 2017-06-05 10:10:57 -07:00
alecmerdler
cfcdcde1bc remove one-time binding to prevent binding to empty string 2017-06-02 20:27:52 -07:00
alecmerdler
1339331de7 subscribe to activeTab changes in ngAfterContentInit to ensure panel exists 2017-06-02 20:17:42 -07:00
alecmerdler
9da1487bbc improve cor-tabs architecture 2017-06-02 18:03:30 -07:00
Erica
ca5f588c44 Merge pull request #2672 from coreos-inc/FIX-user-service-async 
fix(user-service): make sync calls to update user async
 2017-05-26 17:55:07 -04:00
josephschorr
e3445a5723 Merge pull request #2669 from coreos-inc/app-repo-view 
Add messaging if viewing a repo via the wrong path
 2017-05-26 17:22:36 -04:00
EvB
20284f57f3 fix(user-service): make sync calls to update user async 2017-05-26 17:18:05 -04:00
alecmerdler
d5e35156e0 ensure @Input bindings are not undefined before executing trigger logic 2017-05-26 12:53:23 -07:00