vbatts/quay
Archived
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
8493 commits 2 branches 62 tags 205 MiB
Commit graph

66 commits

Author SHA1 Message Date
Joseph Schorr
1be22a9a56
Merge pull request #3110 from quay/joseph.schorr/QUAY-966/gitlab-v4 
Reimplement GitLab trigger handler using the V4 API library
 2018-06-12 17:03:31 -04:00
Joseph Schorr
bf966545ba Reimplement GitLab trigger handler using the V4 API library 
GitLab has deprecated and removed the V3 API entirely

Fixes https://jira.coreos.com/browse/QUAY-966
 2018-06-12 15:01:37 -04:00
Joseph Schorr
19ba7c6ddc Combine githost tests, as the disable test was (inadvertently) relying on the state of the enable test 2018-06-01 17:07:04 -04:00
Kyle Brown
b8f5a9a22d Fix bug in Github trigger set up flow 2017-10-23 19:57:53 -07:00
Joseph Schorr
bf41aedc9c Have gitlab default to True on permissions if they are missing 
This allows the repositories to be selected in the UI, if we are unsure whether the user has permission. Since gitlab will do the check anyway, this is safe, although not a great user experience if they chose an invalid repository, but we can't really do much about that.
 2017-05-02 13:11:57 -04:00
Joseph Schorr
ae7012eef2 Anything can be None in GitLab! 
Fixes a problem where the `project_access` block is reported as `null` from GitLab API, which breaks our code, because we assume sanity in API design.
 2017-05-01 20:09:18 -04:00
Joseph Schorr
69ff58f7bd Gitlab can return None for avatar blocks 
Because reasons!
 2017-04-21 17:37:00 -04:00
Joseph Schorr
c8950f34b1 Fix avatar URLs for non-owner namespaces in Gitlab 2017-04-11 15:00:20 -04:00
Joseph Schorr
eae151ff96 Allow null avatars from Gitlab 
Not all gitlab repositories have defined owners, meaning we cannot always get an avatar_url for the namespace

Fixes https://sentry.io/coreos/backend-production/issues/241774339/
 2017-04-04 13:41:38 -04:00
Charlton Austin
e6d201e0b0 feat(build runner): added in context, dockerfile_location 
this is a new feature meant to allow people to use any file as
  a dockerfile and any folder as a context directory
 2017-03-28 13:55:31 -04:00
Joseph Schorr
6476488221 Skip bitbucket pushes without any commits 
Fixes https://sentry.io/coreos/backend-production/issues/178220183/
 2017-03-20 18:23:21 -04:00
Joseph Schorr
4cb8412fd8 Fix NoneType error in GH trigger when it has no pushed_at field 
This appears to occur in new repositories that have not yet been pushed.

Fixes https://sentry.io/coreos/backend-production/issues/234686591/
 2017-03-20 18:14:50 -04:00
Joseph Schorr
6f567e0850 Add tests for build web hooks endpoint 2017-03-20 13:22:59 -04:00
Charlton Austin
d6e45e3321 fix(buildtrigger): fixed error from github api 
there was a 500 being thrown every time there was a slash at the end of a directory while adding in a new trigger this stops that 500 from coming
 2017-03-10 13:04:41 -05:00
Joseph Schorr
a15abd3b5c Fix API exception in trigger setup due to invalid Dockerfile path 2017-03-07 19:25:18 -05:00
Charlton Austin
e30cd931d1 feat(buildtrigger): allow use to specify dockerfile 
users can only specify the folder and the
  dockerfile must be names "Dockerfile" this allows
  users to specify the file and it can be called
  "Dockerfile" or <some name>.Dockerfile
 2017-03-06 21:20:17 -05:00
Joseph Schorr
81e96d6c1d Fix merge breakage 2017-03-02 16:33:47 -05:00
Joseph Schorr
c3edc3855a Fix build trigger tests 2017-02-28 17:19:17 -05:00
Joseph Schorr
b403906bc8 Fix flakiness in new tests due to change in hash seed 2017-02-28 17:19:17 -05:00
Joseph Schorr
c9bddd9c9a Remove unnecessary check 2017-02-28 17:19:17 -05:00
Joseph Schorr
e025d8c2b2 Add schema validation of namespaces and sources methods 2017-02-28 17:19:17 -05:00
Joseph Schorr
57528aa2bc Add unit testing of gitlab trigger handler 2017-02-28 17:19:17 -05:00
Joseph Schorr
84b298f36b Add missing bitbucket test 2017-02-28 17:19:17 -05:00
Joseph Schorr
497c90e7ea Add unit testing of bitbucket trigger handler 2017-02-28 17:19:17 -05:00
Joseph Schorr
ba301b401b Break common git hosts tests into their own suite 2017-02-28 17:19:17 -05:00
Joseph Schorr
c4f873ae96 Add unit testing of github trigger handler 2017-02-28 17:19:16 -05:00
Joseph Schorr
cfe231f618 Add unit testing of custom trigger handler 2017-02-28 17:19:16 -05:00
alecmerdler
a5fc7cba5f use minified AngularJS 2017-02-28 16:52:16 -05:00
Joseph Schorr
8e863b8cf5 Implement new create and manager trigger UI 
Implements the new trigger setup user interface, which is now a linear workflow found on its own page, rather than a tiny modal dialog

Fixes #1187
 2017-02-28 16:51:42 -05:00
Joseph Schorr
9db20ff961 Catch SSL errors due to timeouts in Github calls 
Fixes https://sentry.io/coreos/backend-production/issues/219378902/
 2017-02-22 13:20:04 -05:00
Joseph Schorr
a34d18b9ea Fix handling of gitlab web hooks when tagging 
Gitlab doesn't send any commit information for tagging events (because... reasons), and so we have to perform the lookup ourselves to have full metadata.

Fixes #1467
 2017-02-16 15:40:37 -05:00
Joseph Schorr
9600d3c2fc Make sure we never have a None default branch 
Fixes #2134
 2016-11-17 14:22:01 -05:00
josephschorr
c4b73318c0 Merge pull request #2126 from coreos-inc/github-empty 
Fix github trigger when submitting a webhook without a head_commit
 2016-11-17 12:01:59 -05:00
Joseph Schorr
8c78d967f8 Fix KeyError in Github trigger setup 
Fixes #2128
 2016-11-16 15:54:08 -05:00
Joseph Schorr
69e2cfad70 Fix github trigger when submitting a webhook without a head_commit 
Fixes #2125
 2016-11-16 14:14:17 -05:00
josephschorr
0954240ccb Merge pull request #2060 from coreos-inc/gitlab-user-exception 
Fix TypeError in Gitlab trigger when user not found
 2016-10-31 13:37:45 -04:00
Joseph Schorr
99ea0a9009 Fix TypeError in Gitlab trigger when user not found 
Fixes #2055
 2016-10-31 13:31:26 -04:00
Joseph Schorr
b0b47bbfde Fix KeyError in config when not present in BitBucket trigger 
Fixes #2054
 2016-10-31 13:26:58 -04:00
Joseph Schorr
26e8e241da Fix handling of Gitlab payloads with multiple commits 
Gitlab sends multiple commits in the order reversed from Github. As this only broke recently, I suspect that they may have changed the ordering. This change makes the code order-agnostic to hopefully remove the problem going forward.

Fixes #1900
 2016-09-30 12:14:32 +02:00
Joseph Schorr
c43173576a Fix Gitlab trigger payload bug when commits is empty 
Gitlab will occasionally send trigger payloads with an empty commit list (and a null checkout_ha) for branches that have been deleted. Properly handle that case.
 2016-09-30 12:03:08 +02:00
Joseph Schorr
406cd942d2 Fix manual run under bitbucket repos with many tags/branches 
Fixes #1766

Depends on merging of https://github.com/coreos/py-bitbucket/pull/3 and then a regeneration of the requirements.txt
 2016-08-25 18:24:35 -04:00
Joseph Schorr
626042b10a Fix exception in Gitlab trigger when project is not present 
Fixes #1629
 2016-07-26 15:18:43 -07:00
Evan Cordell
eba75494d9 Use new error format for auth errors (factor exceptions into module) 2016-04-11 16:22:26 -04:00
Jimmy Zelinskie
bcea268fcb use app.gitlab_trigger for config data 
This includes defaults and makes the structure of the Gitlab trigger
parallel the GitHub trigger.
 2016-03-18 14:56:09 -04:00
Jimmy Zelinskie
675e1799d8 remove hardcoded host in gitlab get_repository_url 2016-03-18 14:56:09 -04:00
Joseph Schorr
6a8331d305 Tests for endpoints/web and some small fixes 2016-02-05 09:45:25 +02:00
Joseph Schorr
f99e74f0a1 Support all schemas in the custom trigger 
Fixes #266
 2015-12-01 16:59:24 -05:00
Silas Sewell
4f9a7b3482 Fix missing GithubException ref 2015-11-04 11:19:49 -05:00
Jimmy Zelinskie
c7fba332e6 fix handling missing authors for Bitbucket 
The author was accidentally always being initialized as a JSONPathDict,
thus the `if` expression following was always true.

Fixes #733.
 2015-10-29 14:14:05 -04:00
Joseph Schorr
c33ae0e896 BitBucket is being slow - increase the timeout 
Fixes #721
 2015-10-26 14:29:29 -04:00