Commit graph

24 commits

Author SHA1 Message Date
Joseph Schorr
63ed683dfa Small fixes for GitLab trigger handler, since the GitLab API is returning the wrong ID for the user's namespace
Also has a small UI improvement
2018-06-13 15:12:05 -04:00
Joseph Schorr
1be22a9a56
Merge pull request #3110 from quay/joseph.schorr/QUAY-966/gitlab-v4
Reimplement GitLab trigger handler using the V4 API library
2018-06-12 17:03:31 -04:00
Joseph Schorr
bf966545ba Reimplement GitLab trigger handler using the V4 API library
GitLab has deprecated and removed the V3 API entirely

Fixes https://jira.coreos.com/browse/QUAY-966
2018-06-12 15:01:37 -04:00
Joseph Schorr
19ba7c6ddc Combine githost tests, as the disable test was (inadvertently) relying on the state of the enable test 2018-06-01 17:07:04 -04:00
Joseph Schorr
bf41aedc9c Have gitlab default to True on permissions if they are missing
This allows the repositories to be selected in the UI, if we are unsure whether the user has permission. Since gitlab will do the check anyway, this is safe, although not a great user experience if they chose an invalid repository, but we can't really do much about that.
2017-05-02 13:11:57 -04:00
Joseph Schorr
ae7012eef2 Anything can be None in GitLab!
Fixes a problem where the `project_access` block is reported as `null` from GitLab API, which breaks our code, because we assume sanity in API design.
2017-05-01 20:09:18 -04:00
Joseph Schorr
69ff58f7bd Gitlab can return None for avatar blocks
Because reasons!
2017-04-21 17:37:00 -04:00
Joseph Schorr
c8950f34b1 Fix avatar URLs for non-owner namespaces in Gitlab 2017-04-11 15:00:20 -04:00
Charlton Austin
e6d201e0b0 feat(build runner): added in context, dockerfile_location
this is a new feature meant to allow people to use any file as
  a dockerfile and any folder as a context directory
2017-03-28 13:55:31 -04:00
Joseph Schorr
4cb8412fd8 Fix NoneType error in GH trigger when it has no pushed_at field
This appears to occur in new repositories that have not yet been pushed.

Fixes https://sentry.io/coreos/backend-production/issues/234686591/
2017-03-20 18:14:50 -04:00
Joseph Schorr
6f567e0850 Add tests for build web hooks endpoint 2017-03-20 13:22:59 -04:00
Charlton Austin
d6e45e3321 fix(buildtrigger): fixed error from github api
there was a 500 being thrown every time there was a slash at the end of a directory while adding in a new trigger this stops that 500 from coming
2017-03-10 13:04:41 -05:00
Joseph Schorr
a15abd3b5c Fix API exception in trigger setup due to invalid Dockerfile path 2017-03-07 19:25:18 -05:00
Charlton Austin
e30cd931d1 feat(buildtrigger): allow use to specify dockerfile
users can only specify the folder and the
  dockerfile must be names "Dockerfile" this allows
  users to specify the file and it can be called
  "Dockerfile" or <some name>.Dockerfile
2017-03-06 21:20:17 -05:00
Joseph Schorr
c3edc3855a Fix build trigger tests 2017-02-28 17:19:17 -05:00
Joseph Schorr
b403906bc8 Fix flakiness in new tests due to change in hash seed 2017-02-28 17:19:17 -05:00
Joseph Schorr
c9bddd9c9a Remove unnecessary check 2017-02-28 17:19:17 -05:00
Joseph Schorr
e025d8c2b2 Add schema validation of namespaces and sources methods 2017-02-28 17:19:17 -05:00
Joseph Schorr
57528aa2bc Add unit testing of gitlab trigger handler 2017-02-28 17:19:17 -05:00
Joseph Schorr
84b298f36b Add missing bitbucket test 2017-02-28 17:19:17 -05:00
Joseph Schorr
497c90e7ea Add unit testing of bitbucket trigger handler 2017-02-28 17:19:17 -05:00
Joseph Schorr
ba301b401b Break common git hosts tests into their own suite 2017-02-28 17:19:17 -05:00
Joseph Schorr
c4f873ae96 Add unit testing of github trigger handler 2017-02-28 17:19:16 -05:00
Joseph Schorr
cfe231f618 Add unit testing of custom trigger handler 2017-02-28 17:19:16 -05:00