Joseph Schorr
26e8e241da
Fix handling of Gitlab payloads with multiple commits
...
Gitlab sends multiple commits in the order reversed from Github. As this only broke recently, I suspect that they may have changed the ordering. This change makes the code order-agnostic to hopefully remove the problem going forward.
Fixes #1900
2016-09-30 12:14:32 +02:00
Joseph Schorr
c43173576a
Fix Gitlab trigger payload bug when commits is empty
...
Gitlab will occasionally send trigger payloads with an empty commit list (and a null checkout_ha) for branches that have been deleted. Properly handle that case.
2016-09-30 12:03:08 +02:00
Joseph Schorr
406cd942d2
Fix manual run under bitbucket repos with many tags/branches
...
Fixes #1766
Depends on merging of https://github.com/coreos/py-bitbucket/pull/3 and then a regeneration of the requirements.txt
2016-08-25 18:24:35 -04:00
Joseph Schorr
626042b10a
Fix exception in Gitlab trigger when project is not present
...
Fixes #1629
2016-07-26 15:18:43 -07:00
Evan Cordell
eba75494d9
Use new error format for auth errors (factor exceptions into module)
2016-04-11 16:22:26 -04:00
Jimmy Zelinskie
bcea268fcb
use app.gitlab_trigger for config data
...
This includes defaults and makes the structure of the Gitlab trigger
parallel the GitHub trigger.
2016-03-18 14:56:09 -04:00
Jimmy Zelinskie
675e1799d8
remove hardcoded host in gitlab get_repository_url
2016-03-18 14:56:09 -04:00
Joseph Schorr
6a8331d305
Tests for endpoints/web and some small fixes
2016-02-05 09:45:25 +02:00
Joseph Schorr
f99e74f0a1
Support all schemas in the custom trigger
...
Fixes #266
2015-12-01 16:59:24 -05:00
Silas Sewell
4f9a7b3482
Fix missing GithubException ref
2015-11-04 11:19:49 -05:00
Jimmy Zelinskie
c7fba332e6
fix handling missing authors for Bitbucket
...
The author was accidentally always being initialized as a JSONPathDict,
thus the `if` expression following was always true.
Fixes #733 .
2015-10-29 14:14:05 -04:00
Joseph Schorr
c33ae0e896
BitBucket is being slow - increase the timeout
...
Fixes #721
2015-10-26 14:29:29 -04:00
Quentin Machu
37a4dafe40
Use expected exception for BitBucket OAuth error
...
Prevents from having a 500 when BitBucket OAuth doesn't work, as it will be caught in web.py/attach_bitbucket_trigger
2015-10-22 11:24:17 -04:00
Quentin Machu
674c16bf3b
Add logging on BitBucket schema validation exception
...
Chatty but worthy
No need to create a custom debugging web hook anymore for Bitbucket
2015-10-22 11:21:34 -04:00
Joseph Schorr
d9e001b688
Better GitHub error messaging
...
Fixes #612
2015-10-16 13:51:50 -04:00
Jimmy Zelinskie
7c1547221d
raise a 520 for any GitLab timeouts
2015-10-13 17:34:08 -04:00
Jimmy Zelinskie
d2c4a465e3
add default HTTP timeout to GitLab
...
Fixes #623 .
2015-10-13 14:51:28 -04:00
Jimmy Zelinskie
0e27852444
Merge pull request #631 from jzelinskie/glfix
...
remove network usage from GL repo URL
2015-10-13 13:46:27 -04:00
Jimmy Zelinskie
7dfe6691ec
remove network usage from GL repo URL
...
Fixes #624 .
2015-10-13 12:44:56 -04:00
Joseph Schorr
775b47c851
Make sure we have defined timeouts on all our requests out to external build services
...
Fixes #623
2015-10-13 11:21:53 -04:00
Joseph Schorr
eaf81959f5
Handle the case where we have lookup_user but no username
2015-09-28 17:12:56 -04:00
Joseph Schorr
18cfe676ee
Fix GH schema for missing usernames and add test
2015-09-25 15:12:24 -04:00
Joseph Schorr
85ed745433
Fix bitbucket trigger validation for commits without authors
2015-09-25 12:03:21 -04:00
Jimmy Zelinskie
7372068a72
fix skipping builds with custom-git
...
Custom git triggers don't necessarily have commit info available. Our
code reading the commit message was under the assumption that it would
always be there.
2015-09-22 16:51:23 -04:00
Joseph Schorr
ee836da1e3
Fix raise_if_skipped_build calls
2015-09-22 15:05:25 -04:00
Joseph Schorr
05c9a5f7b8
Fix the skip branch logic
2015-09-22 14:44:49 -04:00
Joseph Schorr
272326ae18
Add schema validation to all external trigger types
2015-09-21 17:46:50 -04:00
Joseph Schorr
49b575afb6
Start refactoring of the trigger system:
...
- Move each trigger handler into its own file
- Add dictionary helper classes for easier reading and writing of dict-based data
- Extract the web hook payload -> internal representation building for each trigger system
- Add tests for this transformation
- Remove support for Github archived-based building
2015-09-21 16:36:48 -04:00
