Allows storagedriver parameter values to be of type interface{}

This enables use of nil, booleans, numeric types, and even complex structures for parameter values, assuming they can be parsed from yaml.

storagedriver/factory/factory.go

@@ -16,7 +16,7 @@ type StorageDriverFactory interface {
 	// Create returns a new storagedriver.StorageDriver with the given parameters
 	// Parameters will vary by driver and may be ignored
 	// Each parameter key must only consist of lowercase letters and numbers
-	Create(parameters map[string]string) (storagedriver.StorageDriver, error)
+	Create(parameters map[string]interface{}) (storagedriver.StorageDriver, error)
 }
 
 // Register makes a storage driver available by the provided name.
@@ -37,7 +37,7 @@ func Register(name string, factory StorageDriverFactory) {
 // To run in-process, the StorageDriverFactory must first be registered with the given name
 // If no in-process drivers are found with the given name, this attempts to create an IPC driver
 // If no in-process or external drivers are found, an InvalidStorageDriverError is returned
-func Create(name string, parameters map[string]string) (storagedriver.StorageDriver, error) {
+func Create(name string, parameters map[string]interface{}) (storagedriver.StorageDriver, error) {
 	driverFactory, ok := driverFactories[name]
 	if !ok {
 		return nil, InvalidStorageDriverError{name}

storagedriver/filesystem/driver.go

@@ -23,7 +23,7 @@ func init() {
 // filesystemDriverFactory implements the factory.StorageDriverFactory interface
 type filesystemDriverFactory struct{}
 
-func (factory *filesystemDriverFactory) Create(parameters map[string]string) (storagedriver.StorageDriver, error) {
+func (factory *filesystemDriverFactory) Create(parameters map[string]interface{}) (storagedriver.StorageDriver, error) {
 	return FromParameters(parameters), nil
 }
 
@@ -36,12 +36,12 @@ type Driver struct {
 // FromParameters constructs a new Driver with a given parameters map
 // Optional Parameters:
 // - rootdirectory
-func FromParameters(parameters map[string]string) *Driver {
+func FromParameters(parameters map[string]interface{}) *Driver {
 	var rootDirectory = defaultRootDirectory
 	if parameters != nil {
 		rootDir, ok := parameters["rootdirectory"]
 		if ok {
-			rootDirectory = rootDir
+			rootDirectory = fmt.Sprint(rootDir)
 		}
 	}
 	return New(rootDirectory)

storagedriver/inmemory/driver.go

@@ -21,7 +21,7 @@ func init() {
 // inMemoryDriverFacotry implements the factory.StorageDriverFactory interface.
 type inMemoryDriverFactory struct{}
 
-func (factory *inMemoryDriverFactory) Create(parameters map[string]string) (storagedriver.StorageDriver, error) {
+func (factory *inMemoryDriverFactory) Create(parameters map[string]interface{}) (storagedriver.StorageDriver, error) {
 	return New(), nil
 }