vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

testutil, storage: use math/rand.Read where possible

Browse source 
Use the much faster math/rand.Read function where cryptographic
guarantees are not required. The unit test suite should speed up a
little bit but we've already optimized around this, so it may not
matter.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2016-08-08 17:16:23 -07:00
parent bfa0a9c097
commit 040db51795
No known key found for this signature in database
GPG key ID: FB5F6B2905D7ECF3
3 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
testutil/tarfile.go
View file

@ -3,7 +3,6 @@ package testutil
import (
"archive/tar"
"bytes"
"crypto/rand"
"fmt"
"io"
mrand "math/rand"
@ -46,7 +45,7 @@ func CreateRandomTarFile() (rs io.ReadSeeker, dgst digest.Digest, err error) {
randomData := make([]byte, fileSize)
// Fill up the buffer with some random data.
n, err := rand.Read(randomData)
n, err := mrand.Read(randomData)
if n != len(randomData) {
return nil, "", fmt.Errorf("short read creating random reader: %v bytes != %v bytes", n, len(randomData))