vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

registry: fix binary JSON content-type

Browse source 
This fixes registry endpoints to return the proper `application/json`
content-type for JSON content, also updating spec examples for that.

As per IETF specification and IANA registry [0], the `application/json`
type is a binary media, so the content-type label does not need any
text-charset selector. Additionally, the media type definition
explicitly states that it has no required nor optional parameters,
which makes the current registry headers non-compliant.

[0]: https://www.iana.org/assignments/media-types/application/json

Signed-off-by: Luca Bruno <lucab@debian.org>
This commit is contained in:
Luca Bruno 2019-01-14 08:53:03 +00:00 • committed by Luca Bruno
parent 91b0f0559e
commit 15b0204758
No known key found for this signature in database
GPG key ID: A9834A2252078E4E
12 changed files with 135 additions and 135 deletions
Download patch file Download diff file Expand all files Collapse all files

2
health/health.go
View file

@ -291,7 +291,7 @@ func statusResponse(w http.ResponseWriter, r *http.Request, status int, checks m
}
}
w.Header().Set("Content-Type", "application/json; charset=utf-8")
w.Header().Set("Content-Type", "application/json")
w.Header().Set("Content-Length", fmt.Sprint(len(p)))
w.WriteHeader(status)
if _, err := w.Write(p); err != nil {