From 16445b67679e91eab408a40a34625aa1f4dabfd1 Mon Sep 17 00:00:00 2001
From: Richard Scothern <richard.scothern@gmail.com>
Date: Wed, 17 Feb 2016 10:42:34 -0800
Subject: [PATCH] Extend authChallenger interface to remove type cast.

Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
---
 registry/proxy/proxyauth.go               |  2 +-
 registry/proxy/proxymanifeststore_test.go | 17 ++++++---
 registry/proxy/proxyregistry.go           | 43 +++++++++++++----------
 3 files changed, 39 insertions(+), 23 deletions(-)

diff --git a/registry/proxy/proxyauth.go b/registry/proxy/proxyauth.go
index bcfa7aab..6f0eb005 100644
--- a/registry/proxy/proxyauth.go
+++ b/registry/proxy/proxyauth.go
@@ -25,7 +25,7 @@ func (c credentials) Basic(u *url.URL) (string, string) {
 	return up.username, up.password
 }
 
-// ConfigureAuth stores credentials for challenge responses
+// configureAuth stores credentials for challenge responses
 func configureAuth(username, password string) (auth.CredentialStore, error) {
 	creds := map[string]userpass{
 		tokenURL: {
diff --git a/registry/proxy/proxymanifeststore_test.go b/registry/proxy/proxymanifeststore_test.go
index e16fa6f5..312eb343 100644
--- a/registry/proxy/proxymanifeststore_test.go
+++ b/registry/proxy/proxymanifeststore_test.go
@@ -11,6 +11,7 @@ import (
 	"github.com/docker/distribution/manifest"
 	"github.com/docker/distribution/manifest/schema1"
 	"github.com/docker/distribution/reference"
+	"github.com/docker/distribution/registry/client/auth"
 	"github.com/docker/distribution/registry/proxy/scheduler"
 	"github.com/docker/distribution/registry/storage"
 	"github.com/docker/distribution/registry/storage/cache/memory"
@@ -71,11 +72,19 @@ type mockChallenger struct {
 }
 
 // Called for remote operations only
-func (mc *mockChallenger) tryEstablishChallenges(context.Context) error {
-	mc.Lock()
-	defer mc.Unlock()
+func (m *mockChallenger) tryEstablishChallenges(context.Context) error {
+	m.Lock()
+	defer m.Unlock()
 
-	mc.count++
+	m.count++
+	return nil
+}
+
+func (m *mockChallenger) credentialStore() auth.CredentialStore {
+	return nil
+}
+
+func (m *mockChallenger) challengeManager() auth.ChallengeManager {
 	return nil
 }
 
diff --git a/registry/proxy/proxyregistry.go b/registry/proxy/proxyregistry.go
index 0f5248ff..0c51a022 100644
--- a/registry/proxy/proxyregistry.go
+++ b/registry/proxy/proxyregistry.go
@@ -101,9 +101,9 @@ func NewRegistryPullThroughCache(ctx context.Context, registry distribution.Name
 		scheduler: s,
 		remoteURL: config.RemoteURL,
 		authChallenger: &remoteAuthChallenger{
-			remoteURL:        config.RemoteURL,
-			challengeManager: auth.NewSimpleChallengeManager(),
-			credentialStore:  cs,
+			remoteURL: config.RemoteURL,
+			cm:        auth.NewSimpleChallengeManager(),
+			cs:        cs,
 		},
 	}, nil
 }
@@ -117,13 +117,10 @@ func (pr *proxyingRegistry) Repositories(ctx context.Context, repos []string, la
 }
 
 func (pr *proxyingRegistry) Repository(ctx context.Context, name reference.Named) (distribution.Repository, error) {
-	hcm, ok := pr.authChallenger.(*remoteAuthChallenger)
-	if !ok {
-		return nil, fmt.Errorf("unexpected challenge manager type %T", pr.authChallenger)
-	}
+	c := pr.authChallenger
 
 	tr := transport.NewTransport(http.DefaultTransport,
-		auth.NewAuthorizer(hcm.challengeManager, auth.NewTokenHandler(http.DefaultTransport, hcm.credentialStore, name.Name(), "pull")))
+		auth.NewAuthorizer(c.challengeManager(), auth.NewTokenHandler(http.DefaultTransport, c.credentialStore(), name.Name(), "pull")))
 
 	localRepo, err := pr.embedded.Repository(ctx, name)
 	if err != nil {
@@ -172,22 +169,32 @@ func (pr *proxyingRegistry) Repository(ctx context.Context, name reference.Named
 // authChallenger encapsulates a request to the upstream to establish credential challenges
 type authChallenger interface {
 	tryEstablishChallenges(context.Context) error
+	challengeManager() auth.ChallengeManager
+	credentialStore() auth.CredentialStore
 }
 
 type remoteAuthChallenger struct {
 	remoteURL string
 	sync.Mutex
-	challengeManager auth.ChallengeManager
-	credentialStore  auth.CredentialStore
+	cm auth.ChallengeManager
+	cs auth.CredentialStore
 }
 
-// tryEstablishChallenges will attempt to get a challenge types for the upstream if none currently exist
-func (hcm *remoteAuthChallenger) tryEstablishChallenges(ctx context.Context) error {
-	hcm.Lock()
-	defer hcm.Unlock()
+func (r *remoteAuthChallenger) credentialStore() auth.CredentialStore {
+	return r.cs
+}
 
-	remoteURL := hcm.remoteURL + "/v2/"
-	challenges, err := hcm.challengeManager.GetChallenges(remoteURL)
+func (r *remoteAuthChallenger) challengeManager() auth.ChallengeManager {
+	return r.cm
+}
+
+// tryEstablishChallenges will attempt to get a challenge type for the upstream if none currently exist
+func (r *remoteAuthChallenger) tryEstablishChallenges(ctx context.Context) error {
+	r.Lock()
+	defer r.Unlock()
+
+	remoteURL := r.remoteURL + "/v2/"
+	challenges, err := r.cm.GetChallenges(remoteURL)
 	if err != nil {
 		return err
 	}
@@ -197,11 +204,11 @@ func (hcm *remoteAuthChallenger) tryEstablishChallenges(ctx context.Context) err
 	}
 
 	// establish challenge type with upstream
-	if err := ping(hcm.challengeManager, remoteURL, challengeHeader); err != nil {
+	if err := ping(r.cm, remoteURL, challengeHeader); err != nil {
 		return err
 	}
 
-	context.GetLogger(ctx).Infof("Challenge established with upstream : %s %s", remoteURL, hcm.challengeManager)
+	context.GetLogger(ctx).Infof("Challenge established with upstream : %s %s", remoteURL, r.cm)
 	return nil
 }