vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't wrap thead limits when using a negative int

Browse source 
Signed-off-by: Tony Holdstock-Brown <tony@docker.com>
This commit is contained in:
Tony Holdstock-Brown 2016-05-03 16:03:22 -07:00
parent cbae4dd7bf
commit 1e05d81a71
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
docs/storage/driver/filesystem/driver.go
View file

@ -96,7 +96,12 @@ func fromParametersImpl(parameters map[string]interface{}) (*DriverParameters, e
case uint64: case uint64:
maxThreads = v maxThreads = v
case int, int32, int64: case int, int32, int64:
maxThreads = uint64(reflect.ValueOf(v).Convert(reflect.TypeOf(threads)).Int()) val := reflect.ValueOf(v).Convert(reflect.TypeOf(threads)).Int()
// If threads is negative casting to uint64 will wrap around and
// give you the hugest thread limit ever. Let's be sensible, here
if val > 0 {
maxThreads = uint64(val)
}
case uint, uint32: case uint, uint32:
maxThreads = reflect.ValueOf(v).Convert(reflect.TypeOf(threads)).Uint() maxThreads = reflect.ValueOf(v).Convert(reflect.TypeOf(threads)).Uint()
case nil: case nil: