vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix tests after #846

Browse source 
Change checkResponse to only expect the configured
X-Content-Type-Options header if it doesn't receive a 405 error, which
means the handler isn't registered for that method.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
This commit is contained in:
Aaron Lehmann 2015-08-18 13:33:26 -07:00
parent 0c16d42a4a
commit 2e4c643419
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/handlers/api_test.go
View file

@ -1248,8 +1248,10 @@ func checkResponse(t *testing.T, msg string, resp *http.Response, expectedStatus
t.FailNow() t.FailNow()
} }
// We expect the headers included in the configuration // We expect the headers included in the configuration, unless the
if !reflect.DeepEqual(resp.Header["X-Content-Type-Options"], []string{"nosniff"}) { // status code is 405 (Method Not Allowed), which means the handler
// doesn't even get called.
if resp.StatusCode != 405 && !reflect.DeepEqual(resp.Header["X-Content-Type-Options"], []string{"nosniff"}) {
t.Logf("missing or incorrect header X-Content-Type-Options %s", msg) t.Logf("missing or incorrect header X-Content-Type-Options %s", msg)
maybeDumpResponse(t, resp) maybeDumpResponse(t, resp)