vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #1966 from nwt/fix-redis-tests

Browse source 
Fix connection pool exhaustion in Redis tests
This commit is contained in:
Richard Scothern 2016-09-19 16:27:56 -07:00 committed by GitHub
commit 431cfa3179
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
registry/storage/cache/redis/redis_test.go vendored
View file

@ -26,7 +26,7 @@ func TestRedisBlobDescriptorCacheProvider(t *testing.T) {
if redisAddr == "" { if redisAddr == "" {
// skip if still not set // skip if still not set
t.Skip("please set -registry.storage.cache.redis to test layer info cache against redis") t.Skip("please set -test.registry.storage.cache.redis.addr to test layer info cache against redis")
} }
pool := &redis.Pool{ pool := &redis.Pool{
@ -43,9 +43,11 @@ func TestRedisBlobDescriptorCacheProvider(t *testing.T) {
} }
// Clear the database // Clear the database
if _, err := pool.Get().Do("FLUSHDB"); err != nil { conn := pool.Get()
if _, err := conn.Do("FLUSHDB"); err != nil {
t.Fatalf("unexpected error flushing redis db: %v", err) t.Fatalf("unexpected error flushing redis db: %v", err)
} }
conn.Close()
cachecheck.CheckBlobDescriptorCache(t, NewRedisBlobDescriptorCacheProvider(pool)) cachecheck.CheckBlobDescriptorCache(t, NewRedisBlobDescriptorCacheProvider(pool))
} }