Use references terminology instead of layers.

Signed-off-by: Andrew Leung <anwleung@gmail.com>
This commit is contained in:
Andrew Leung 2018-08-20 10:01:40 -07:00
parent 54aef6251e
commit 5e4b81a578
8 changed files with 29 additions and 29 deletions

View file

@ -12,12 +12,12 @@ import (
)
type bridge struct {
ub URLBuilder
manifestLayers bool
actor ActorRecord
source SourceRecord
request RequestRecord
sink Sink
ub URLBuilder
includeReferences bool
actor ActorRecord
source SourceRecord
request RequestRecord
sink Sink
}
var _ Listener = &bridge{}
@ -32,14 +32,14 @@ type URLBuilder interface {
// using the actor and source. Any urls populated in the events created by
// this bridge will be created using the URLBuilder.
// TODO(stevvooe): Update this to simply take a context.Context object.
func NewBridge(ub URLBuilder, source SourceRecord, actor ActorRecord, request RequestRecord, sink Sink, manifestLayers bool) Listener {
func NewBridge(ub URLBuilder, source SourceRecord, actor ActorRecord, request RequestRecord, sink Sink, includeReferences bool) Listener {
return &bridge{
ub: ub,
manifestLayers: manifestLayers,
actor: actor,
source: source,
request: request,
sink: sink,
ub: ub,
includeReferences: includeReferences,
actor: actor,
source: source,
request: request,
sink: sink,
}
}
@ -146,8 +146,8 @@ func (b *bridge) createManifestEvent(action string, repo reference.Named, sm dis
event.Target.Length = desc.Size
event.Target.Size = desc.Size
event.Target.Digest = desc.Digest
if b.manifestLayers {
event.Target.Layers = append(event.Target.Layers, manifest.References()...)
if b.includeReferences {
event.Target.References = append(event.Target.References, manifest.References()...)
}
ref, err := reference.WithDigest(repo, event.Target.Digest)

View file

@ -180,12 +180,12 @@ func checkCommonManifest(t *testing.T, action string, events ...Event) {
t.Fatalf("incorrect url passed: \n%q != \n%q", event.Target.URL, u)
}
if len(event.Target.Layers) != len(layers) {
t.Fatalf("unexpected number of layers %v != %v", len(event.Target.Layers), len(layers))
if len(event.Target.References) != len(layers) {
t.Fatalf("unexpected number of references %v != %v", len(event.Target.References), len(layers))
}
for i, layer := range event.Target.Layers {
if layer.Digest != layers[i].BlobSum {
t.Fatalf("unexpected layer: %q != %q", layer.Digest, layers[i].BlobSum)
for i, targetReference := range event.Target.References {
if targetReference.Digest != layers[i].BlobSum {
t.Fatalf("unexpected reference: %q != %q", targetReference.Digest, layers[i].BlobSum)
}
}
}

View file

@ -72,8 +72,8 @@ type Event struct {
// Tag provides the tag
Tag string `json:"tag,omitempty"`
// Layers provides the layers descriptors.
Layers []distribution.Descriptor `json:"layers,omitempty"`
// References provides the references descriptors.
References []distribution.Descriptor `json:"references,omitempty"`
} `json:"target,omitempty"`
// Request covers the request that generated the event.