Merge pull request #339 from stevvooe/signature-fetch-prevent-false-sharing

registry/storage: prevent false sharing in signature fetch

registry/storage/signaturestore.go

@@ -36,8 +36,13 @@ func (s *signatureStore) Get(dgst digest.Digest) ([][]byte, error) {
 	}
 
 	var wg sync.WaitGroup
-	signatures := make([][]byte, len(signaturePaths)) // make space for everything
+	type result struct {
-	errCh := make(chan error, 1)                      // buffered chan so one proceeds
+		index     int
+		signature []byte
+		err       error
+	}
+	ch := make(chan result)
+
 	for i, sigPath := range signaturePaths {
 		// Append the link portion
 		sigPath = path.Join(sigPath, "link")
@@ -47,33 +52,42 @@ func (s *signatureStore) Get(dgst digest.Digest) ([][]byte, error) {
 			defer wg.Done()
 			context.GetLogger(s.ctx).
 				Debugf("fetching signature from %q", sigPath)
-			p, err := s.blobStore.linked(sigPath)
+
-			if err != nil {
+			r := result{index: idx}
+			if p, err := s.blobStore.linked(sigPath); err != nil {
 				context.GetLogger(s.ctx).
 					Errorf("error fetching signature from %q: %v", sigPath, err)
-
+				r.err = err
-				// try to send an error, if it hasn't already been sent.
+			} else {
-				select {
+				r.signature = p
-				case errCh <- err:
-				default:
-				}
-
-				return
 			}
-			signatures[idx] = p
+
+			ch <- r
 		}(i, sigPath)
 	}
-	wg.Wait()
+	done := make(chan struct{})
+	go func() {
+		wg.Wait()
+		close(done)
+	}()
 
-	select {
+	// aggregrate the results
-	case err := <-errCh:
+	signatures := make([][]byte, len(signaturePaths))
-		// just return the first error, similar to single threaded code.
+loop:
-		return nil, err
+	for {
-	default:
+		select {
-		// pass
+		case result := <-ch:
+			signatures[result.index] = result.signature
+			if result.err != nil && err == nil {
+				// only set the first one.
+				err = result.err
+			}
+		case <-done:
+			break loop
+		}
 	}
 
-	return signatures, nil
+	return signatures, err
 }
 
 func (s *signatureStore) Put(dgst digest.Digest, signatures ...[]byte) error {