vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Unconditionally add AuthTransport.

Browse source 
Today, endpoints implementing v2 cannot properly fallback to v1 because the underlying transport that deals with authentication (Basic / Token) doesn't get annotated.

This doesn't affect DockerHub because the DockerHub endpoint appears as 'https://index.docker.io/v1/' (in .dockercfg), and the 'v1' tricks this logic just long enough that the transport is always annotated for DockerHub accesses.

Signed-off-by: Matt Moore <mattmoor@google.com>
This commit is contained in:
Matt Moore 2015-06-19 10:12:52 -07:00
parent fbec8ef772
commit 79661b8a7e
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/session.go
View file

@ -158,9 +158,9 @@ func NewSession(client *http.Client, authConfig *cliconfig.AuthConfig, endpoint
} }
} }
if endpoint.Version == APIVersion1 { // Annotate the transport unconditionally so that v2 can
client.Transport = AuthTransport(client.Transport, authConfig, alwaysSetBasicAuth) // properly fallback on v1 when an image is not found.
} client.Transport = AuthTransport(client.Transport, authConfig, alwaysSetBasicAuth)
jar, err := cookiejar.New(nil) jar, err := cookiejar.New(nil)
if err != nil { if err != nil {