vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Correctly close pipe after error in tarsum verification

Browse source 
This addresses a subtle deadlock where an error during a copy prevented pipe
closure to propagate correctly. By closing down the read end of the pipe rather
than the write end, the waiting writer is properly signaled. A nice side-effect
of this change is that errors encountered by io.Copy are no propagated to the
verifier's Write method.

A test to ensure validation errors for unsupported digest types has been added,
as well.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2015-03-18 18:26:09 -07:00
parent ac550484be
commit 8c254edb9a
3 changed files with 89 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
digest/digest.go
View file

@ -58,7 +58,7 @@ var (
// ErrDigestInvalidFormat returned when digest format invalid.
ErrDigestInvalidFormat = fmt.Errorf("invalid checksum digest format")
// ErrDigestUnsupported returned when the digest algorithm is unsupported by registry.
// ErrDigestUnsupported returned when the digest algorithm is unsupported.
ErrDigestUnsupported = fmt.Errorf("unsupported digest algorithm")
)