vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Return after error in handler

Browse source 
This adds a missing return statement. It is not strictly needed since if the
io.Copy fails, the Finish operation will fail. Currently, the client reports
both errors where this new code will correctly only report the io.Copy error.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2015-04-23 13:13:13 -07:00
parent 0281f4dce5
commit 8d4b636a60
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/handlers/layerupload.go
View file

@ -202,6 +202,7 @@ func (luh *layerUploadHandler) PutLayerUploadComplete(w http.ResponseWriter, r *
ctxu.GetLogger(luh).Errorf("unknown error copying into upload: %v", err) ctxu.GetLogger(luh).Errorf("unknown error copying into upload: %v", err)
w.WriteHeader(http.StatusInternalServerError) w.WriteHeader(http.StatusInternalServerError)
luh.Errors.Push(v2.ErrorCodeUnknown, err) luh.Errors.Push(v2.ErrorCodeUnknown, err)
return
} }
layer, err := luh.Upload.Finish(dgst) layer, err := luh.Upload.Finish(dgst)