vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Feedback update

Browse source 
Update comments and TODOs
Fix switch style
Updated parse http response to take in reader
Add Cancel implementation
Update blobstore variable name

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
This commit is contained in:
Derek McGowan 2015-05-19 19:18:30 -07:00
parent eb2ac4301f
commit 8db2145b81
4 changed files with 68 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

7
docs/client/errors.go
View file

@ -3,6 +3,7 @@ package client
import (
"encoding/json"
"fmt"
"io"
"io/ioutil"
"net/http"
@ -34,9 +35,9 @@ func (e *UnexpectedHTTPResponseError) Error() string {
return fmt.Sprintf("Error parsing HTTP response: %s: %q", e.ParseErr.Error(), shortenedResponse)
}
func parseHTTPErrorResponse(response *http.Response) error {
func parseHTTPErrorResponse(r io.Reader) error {
var errors v2.Errors
body, err := ioutil.ReadAll(response.Body)
body, err := ioutil.ReadAll(r)
if err != nil {
return err
}
@ -52,7 +53,7 @@ func parseHTTPErrorResponse(response *http.Response) error {
func handleErrorResponse(resp *http.Response) error {
if resp.StatusCode >= 400 && resp.StatusCode < 500 {
return parseHTTPErrorResponse(resp)
return parseHTTPErrorResponse(resp.Body)
}
return &UnexpectedHTTPStatusError{Status: resp.Status}
}