vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Do not replace logger when adding hooks

Browse source 
Because the logger was incorrectly replaced while adding hooks, log output did
not include the version and instance ids. The main issue was the the
logrus.Entry was replaced with the logger, which included no context. Replacing
the logger on the context is not necessary when configuring hooks since we are
configuring the contexts logger directly.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2015-07-23 20:51:11 -07:00
parent ad0440c7ce
commit 911c0d9f85
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
docs/handlers/app.go
View file

@ -298,7 +298,14 @@ func (app *App) configureRedis(configuration *configuration.Configuration) {
// configureLogHook prepares logging hook parameters. // configureLogHook prepares logging hook parameters.
func (app *App) configureLogHook(configuration *configuration.Configuration) { func (app *App) configureLogHook(configuration *configuration.Configuration) {
logger := ctxu.GetLogger(app).(*log.Entry).Logger entry, ok := ctxu.GetLogger(app).(*log.Entry)
if !ok {
// somehow, we are not using logrus
return
}
logger := entry.Logger
for _, configHook := range configuration.Log.Hooks { for _, configHook := range configuration.Log.Hooks {
if !configHook.Disabled { if !configHook.Disabled {
switch configHook.Type { switch configHook.Type {
@ -318,7 +325,6 @@ func (app *App) configureLogHook(configuration *configuration.Configuration) {
} }
} }
} }
app.Context = ctxu.WithLogger(app.Context, logger)
} }
func (app *App) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (app *App) ServeHTTP(w http.ResponseWriter, r *http.Request) {