vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

storage: enforce sorted traversal during Walk

Browse source 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2015-12-01 16:24:31 -08:00
parent 7bf8f846c2
commit 93f92498ce
2 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/storage/walk.go
View file

@ -3,6 +3,7 @@ package storage
import (
"errors"
"fmt"
"sort"
"github.com/docker/distribution/context"
storageDriver "github.com/docker/distribution/registry/storage/driver"
@ -26,7 +27,12 @@ func Walk(ctx context.Context, driver storageDriver.StorageDriver, from string,
if err != nil {
return err
}
sort.Stable(sort.StringSlice(children))
for _, child := range children {
// TODO(stevvooe): Calling driver.Stat for every entry is quite
// expensive when running against backends with a slow Stat
// implementation, such as s3. This is very likely a serious
// performance bottleneck.
fileInfo, err := driver.Stat(ctx, child)
if err != nil {
return err